Issue 906103002: Disable flaky subset of TopControlsManagerTest.*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 906103002: Disable flaky subset of TopControlsManagerTest.* (Closed)

Created:
5 years, 10 months ago by tapted

Modified:
5 years, 10 months ago

Reviewers:
aelias_OOO_until_Jul13

CC:
chromium-reviews, cc-bugs_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable flaky subset of TopControlsManagerTest.* failures on Win x64: TopControlsManagerTest.PinchBeginStartsAnimationIfNecessary TopControlsManagerTest.PartialShownHideAnimation TopControlsManagerTest.PartialShownWithAmbiguousThresholdHides Errors like TopControlsManagerTest.PartialShownHideAnimation (run #1): [ RUN ] TopControlsManagerTest.PartialShownHideAnimation top_controls_manager_unittest.cc(160): error: Expected: (manager->ControlsTopOffset()) \u003C (previous_offset), actual: -100 vs -100 [ FAILED ] TopControlsManagerTest.PartialShownHideAnimation (0 ms) Likely became flaky in r315216. BUG=456617 TBR=aelias@chromium.org Committed: https://crrev.com/0a6a2262669987dce1be4e0519a042bd6e5abf27 Cr-Commit-Position: refs/heads/master@{#315248}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	cc/input/top_controls_manager_unittest.cc	View		3 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906103002/1

5 years, 10 months ago (2015-02-08 23:44:29 UTC) #3

commit-bot: I haz the power

5 years, 10 months ago (2015-02-09 00:11:58 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0a6a2262669987dce1be4e0519a042bd6e5abf27
Cr-Commit-Position: refs/heads/master@{#315248}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages