Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 905823004: Added MockPresentationClient to use in layout tests. (Closed)

Created:
5 years, 10 months ago by whywhat
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added MockPresentationClient to use in layout tests. Blink change with the test follows: https://codereview.chromium.org/906673002/ BUG=412331 Committed: https://crrev.com/49a225f6ecb52b805a99d55e9e37ed7e21ef7c1b Cr-Commit-Position: refs/heads/master@{#315204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -0 lines) Patch
M content/content_shell.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/webkit_test_runner.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/layout_test/webkit_test_runner.cc View 2 chunks +6 lines, -0 lines 0 comments Download
A content/shell/renderer/test_runner/mock_presentation_client.h View 1 chunk +39 lines, -0 lines 0 comments Download
A content/shell/renderer/test_runner/mock_presentation_client.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 4 chunks +12 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_frame_test_proxy.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.h View 3 chunks +3 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
whywhat
PTaL
5 years, 10 months ago (2015-02-06 20:19:21 UTC) #2
Mike West
LGTM.
5 years, 10 months ago (2015-02-07 04:36:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905823004/1
5 years, 10 months ago (2015-02-07 12:44:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 13:32:12 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/49a225f6ecb52b805a99d55e9e37ed7e21ef7c1b Cr-Commit-Position: refs/heads/master@{#315204}
5 years, 10 months ago (2015-02-07 13:33:07 UTC) #7
dsinclair
5 years, 10 months ago (2015-02-07 14:44:27 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/906753002/ by dsinclair@chromium.org.

The reason for reverting is: This is causing layout failures on the blink bots.
They're crashing with the following assertion:

STDERR:
[17800:1287:0207/062834:4514258387182:FATAL:mock_presentation_client.cc(34)]
Check failed: controller_ != controller && (!controller || !controller_). .

Powered by Google App Engine
This is Rietveld 408576698