Fix unittests for Data Saver integration tests

Fix unittests for Data Saver integration tests

The unittests were failing due to various bugs.
These have been fixed.

BUG=456240
Committed: https://crrev.com/d9ae5cad70ce59e3e2d01a0006ab7c9fd48c9eb9
Cr-Commit-Position: refs/heads/master@{#315124}

[bengr, 2015-02-06 19:59:04]

bengr@chromium.org changed reviewers:
+ sclittle@chromium.org

[bengr, 2015-02-06 19:59:04]

sclittle: all

[sclittle, 2015-02-06 20:44:38]

https://codereview.chromium.org/905823003/diff/1/tools/chrome_proxy/integrati...
File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right):

https://codereview.chromium.org/905823003/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:46: # The Via
header is valid if it is the old format or the new format
Update comment - there is no "old format" now

https://codereview.chromium.org/905823003/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:49: return
(any(v[4:] == CHROME_PROXY_VIA_HEADER for v in vias))
nit: I think you can remove the outermost parentheses here.

https://codereview.chromium.org/905823003/diff/1/tools/chrome_proxy/integrati...
File tools/chrome_proxy/integration_tests/chrome_proxy_metrics_unittest.py
(right):

https://codereview.chromium.org/905823003/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics_unittest.py:113: # An
HTML via proxy with the deprecated Via header.
Remove the word "deprecated"

[bengr, 2015-02-06 20:55:14]

https://codereview.chromium.org/905823003/diff/1/tools/chrome_proxy/integrati...
File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right):

https://codereview.chromium.org/905823003/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:46: # The Via
header is valid if it is the old format or the new format
On 2015/02/06 20:44:38, sclittle wrote:
> Update comment - there is no "old format" now

Done.

https://codereview.chromium.org/905823003/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:49: return
(any(v[4:] == CHROME_PROXY_VIA_HEADER for v in vias))
On 2015/02/06 20:44:38, sclittle wrote:
> nit: I think you can remove the outermost parentheses here.

Done.

https://codereview.chromium.org/905823003/diff/1/tools/chrome_proxy/integrati...
File tools/chrome_proxy/integration_tests/chrome_proxy_metrics_unittest.py
(right):

https://codereview.chromium.org/905823003/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics_unittest.py:113: # An
HTML via proxy with the deprecated Via header.
On 2015/02/06 20:44:38, sclittle wrote:
> Remove the word "deprecated"

Done.

[sclittle, 2015-02-06 21:05:30]

LGTM with nit

https://codereview.chromium.org/905823003/diff/20001/tools/chrome_proxy/integ...
File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right):

https://codereview.chromium.org/905823003/diff/20001/tools/chrome_proxy/integ...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:48: # "1.1
Chrome-Compression-Proxy".
nit: can this fit on the line above?

[bengr, 2015-02-06 21:56:33]

New patchsets have been uploaded after l-g-t-m from sclittle@chromium.org

[bengr, 2015-02-06 21:57:01]

https://codereview.chromium.org/905823003/diff/20001/tools/chrome_proxy/integ...
File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right):

https://codereview.chromium.org/905823003/diff/20001/tools/chrome_proxy/integ...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:48: # "1.1
Chrome-Compression-Proxy".
On 2015/02/06 21:05:30, sclittle wrote:
> nit: can this fit on the line above?

Done.

[bengr, 2015-02-06 22:39:18]

The CQ bit was checked by bengr@chromium.org

[commit-bot: I haz the power, 2015-02-06 22:40:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/905823003/40001

[commit-bot: I haz the power, 2015-02-06 22:40:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-06 22:40:12]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[bengr, 2015-02-06 22:42:14]

On 2015/02/06 22:40:12, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

lgtm

[Nicolas Zea, 2015-02-06 22:49:44]

zea@chromium.org changed reviewers:
+ zea@chromium.org

[Nicolas Zea, 2015-02-06 22:49:45]

rubberstamp LGTM

[bengr, 2015-02-06 22:49:56]

The CQ bit was checked by bengr@chromium.org

[commit-bot: I haz the power, 2015-02-06 22:51:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/905823003/40001

[commit-bot: I haz the power, 2015-02-06 22:54:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-06 22:55:31]

Patchset 3 (id:??) landed as
https://crrev.com/d9ae5cad70ce59e3e2d01a0006ab7c9fd48c9eb9
Cr-Commit-Position: refs/heads/master@{#315124}