Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 905773004: Mark pages created during bootstrapping as never-evacuate. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Mark pages created during bootstrapping as never-evacuate. This is to ensure that immutable immortal objects created during bootstrapping are not relocated. R=hpayer@chromium.org Committed: https://crrev.com/515d26063468c392db6ad8efc5cf267a6556c8a5 Cr-Commit-Position: refs/heads/master@{#26625}

Patch Set 1 #

Total comments: 2

Patch Set 2 : like this? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M src/heap/heap.cc View 1 1 chunk +11 lines, -1 line 0 comments Download
M src/heap/mark-compact.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/spaces.h View 3 chunks +10 lines, -1 line 0 comments Download
M src/heap/spaces.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Yang
5 years, 10 months ago (2015-02-11 14:21:22 UTC) #1
Hannes Payer (out of office)
https://codereview.chromium.org/905773004/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/905773004/diff/1/src/heap/mark-compact.cc#newcode245 src/heap/mark-compact.cc:245: if (p->NeverEvacuate()) return; Dont' make the page an evacuation ...
5 years, 10 months ago (2015-02-12 13:20:24 UTC) #2
Yang
On 2015/02/12 13:20:24, Hannes Payer wrote: > https://codereview.chromium.org/905773004/diff/1/src/heap/mark-compact.cc > File src/heap/mark-compact.cc (right): > > https://codereview.chromium.org/905773004/diff/1/src/heap/mark-compact.cc#newcode245 ...
5 years, 10 months ago (2015-02-12 14:07:50 UTC) #3
Hannes Payer (out of office)
lgtm
5 years, 10 months ago (2015-02-12 14:58:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905773004/20001
5 years, 10 months ago (2015-02-12 16:12:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-12 16:47:54 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 16:48:05 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/515d26063468c392db6ad8efc5cf267a6556c8a5
Cr-Commit-Position: refs/heads/master@{#26625}

Powered by Google App Engine
This is Rietveld 408576698