Add metrics for supervised user whitelist installation and uninstallation, and absolute count.

Add metrics for supervised user whitelist installation and uninstallation, and absolute count.

BUG=436459
Committed: https://crrev.com/47146ebf9cb55fd9c4c3a0216a194d041319260d
Cr-Commit-Position: refs/heads/master@{#315235}

[Bernhard Bauer, 2015-02-06 16:07:02]

bauerb@chromium.org changed reviewers:
+ isherman@chromium.org, treib@chromium.org

[Bernhard Bauer, 2015-02-06 16:07:03]

Please review.

Marc: code
Ilya: UMA/histograms

[Marc Treib, 2015-02-06 16:29:15]

lgtm

[Ilya Sherman, 2015-02-06 23:45:49]

LGTM % comments:

https://codereview.chromium.org/905763002/diff/20001/tools/metrics/actions/ac...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/905763002/diff/20001/tools/metrics/actions/ac...
tools/metrics/actions/actions.xml:7130: A new whitelist has been uninstalled for
a supervised user.
nit: I'm not sure what the word "new" means in this sentence -- it might make
more sense without it.

https://codereview.chromium.org/905763002/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/905763002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:12247: +<histogram
name="ManagedUsers.Whitelist.Count" units="whitelists">
Optional nit: Entirely up to you, but I think ".Size" sounds slightly better to
me than ".Count".

https://codereview.chromium.org/905763002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:12251: +  <summary>The number of
whitelists installed for a supervised user.</summary>
Please document when this is recorded.

[Bernhard Bauer, 2015-02-08 14:01:34]

New patchsets have been uploaded after l-g-t-m from
treib@chromium.org,isherman@chromium.org

[Bernhard Bauer, 2015-02-08 14:05:33]

https://codereview.chromium.org/905763002/diff/20001/tools/metrics/actions/ac...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/905763002/diff/20001/tools/metrics/actions/ac...
tools/metrics/actions/actions.xml:7130: A new whitelist has been uninstalled for
a supervised user.
On 2015/02/06 23:45:47, Ilya Sherman wrote:
> nit: I'm not sure what the word "new" means in this sentence -- it might make
> more sense without it.

You're right, it doesn't make sense; this was copy-and-pasted from above.
Removed.

https://codereview.chromium.org/905763002/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/905763002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:12247: +<histogram
name="ManagedUsers.Whitelist.Count" units="whitelists">
On 2015/02/06 23:45:47, Ilya Sherman wrote:
> Optional nit: Entirely up to you, but I think ".Size" sounds slightly better
to
> me than ".Count".

Hm, I would interpret "size" as the size of a whitelist, not as the size of the
set of whitelists.

https://codereview.chromium.org/905763002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:12251: +  <summary>The number of
whitelists installed for a supervised user.</summary>
On 2015/02/06 23:45:48, Ilya Sherman wrote:
> Please document when this is recorded.

Done.

[Bernhard Bauer, 2015-02-08 14:05:37]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2015-02-08 14:06:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/905763002/40001

[commit-bot: I haz the power, 2015-02-08 15:42:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-08 15:43:01]

Patchset 3 (id:??) landed as
https://crrev.com/47146ebf9cb55fd9c4c3a0216a194d041319260d
Cr-Commit-Position: refs/heads/master@{#315235}