DevTools: Reimplemented WI.WatchExpressionsSidebarPane

Source/devtools/front_end/sources/sourcesPanel.css

Index: Source/devtools/front_end/sources/sourcesPanel.css
diff --git a/Source/devtools/front_end/sources/sourcesPanel.css b/Source/devtools/front_end/sources/sourcesPanel.css
index 177cf73ef5e596263cd177dc3de7292503232527..b8dae4eeb047deee38edaf43d86bfb160149d7e0 100644
--- a/Source/devtools/front_end/sources/sourcesPanel.css
+++ b/Source/devtools/front_end/sources/sourcesPanel.css
@@ -136,52 +136,12 @@
     pointer-events: none;
 }
 
-ol.watch-expressions > li.hovered {
-    background-color: #F0F0F0;
-}
-
 .sidebar-tabbed-pane .watch-expressions {
-    margin-top: 17px;
-}
-
-.properties-tree.watch-expressions {
-    padding-left: 0 !important;
-}
-
-.properties-tree.watch-expressions > li {
-    padding-left: 4px;
-}
-
-.properties-tree.watch-expressions > li > .value {
-    display: inline;
-    position: static;
-}
-
-.properties-tree.watch-expressions > li:not(.parent) {
-    margin-left: 1px;
-    padding-left: 15px;
-}
-
-.properties-tree.watch-expressions > li.hovered {
-    padding-right: 14px;
-}
-
-.watch-expressions > li.editing-sub-part .text-prompt {
-    display: block;
-    width: 100%;
-    overflow: hidden;
-}
-
-.watch-expressions > li.editing-sub-part .value,
-.watch-expressions > li.editing-sub-part .separator  {
-    display: none;
-}
-
-li.editing-sub-part .delete-button {
-    display: none !important;
+    margin-top: 14px;
+    padding-top: 3px;
 }
 
-.section .properties .delete-button {
+.watch-expression .delete-button {
     width: 10px;
     height: 10px;
     background-image: url(Images/deleteIcon.png);
@@ -190,11 +150,11 @@ li.editing-sub-part .delete-button {
     background-repeat: no-repeat;
     border: 0 none transparent;
     position: absolute;
-    right: 8px;
+    right: 3px;
     display: none;
 }
 
-.section .properties li.hovered .delete-button {
+.watch-expression.hovered .delete-button {
     display: inline;
 }
 
@@ -249,3 +209,87 @@ li.editing-sub-part .delete-button {
     border-top: 1px solid rgb(189, 189, 189);
     background-color: rgb(255, 255, 194);
 }
+
+.watch-expressions {

[pfeldman, 2015/02/18 20:51:00]

Lets try distilling these styles - seems like you are adding more than there
was.

[sergeyv, 2015/02/19 10:53:46]

Well, I tried

+    overflow-x: hidden;
+    padding-right: 6px;

[pfeldman, 2015/02/18 20:51:00]

use single padding: shorthand

[sergeyv, 2015/02/19 10:53:46]

Done.

+    padding-bottom: 6px;
+    padding-top: 2px;
+}
+
+.watch-expressions .separator {
+    flex-shrink: 0;

[pfeldman, 2015/02/18 20:51:00]

flex: none

[sergeyv, 2015/02/19 10:53:46]

Done.

+}
+
+.watch-expressions .dimmed {
+    opacity: 0.6;
+}
+
+.watch-expression-title {
+    white-space: nowrap;
+    text-overflow: ellipsis;
+    overflow: hidden;
+    line-height: 12px;
+    padding-top: 1px;
+    padding-bottom: 1px;
+    margin-left: 16px;
+}
+
+.watch-expression {
+    position: relative;
+}
+
+.watch-expression .section .header {
+    min-height: 14px;
+    padding-right: 0px;
+}
+
+.watch-expressions .name {
+    color: rgb(136, 19, 145);
+    flex-shrink: 0;
+    white-space: nowrap;
+    text-overflow: ellipsis ;
+    overflow: hidden;
+}
+
+.watch-expressions .separator {
+    flex-shrink: 0;
+}
+
+.watch-expressions .value {
+    white-space: nowrap;
+    display: inline;
+}
+
+.watch-expression .text-prompt {
+    text-overflow: clip;
+    overflow: hidden;
+    white-space: nowrap;
+    padding-left: 4px;
+    -webkit-user-select: text;
+}
+
+.watch-expression .section > .header::before {

[pfeldman, 2015/02/18 20:51:00]

Why is this one necessary?

[sergeyv, 2015/02/19 10:53:46]

By default  it has value 2px, so it is lower than it is need

+    margin-top: 0px;
+}
+
+.section .watch-expression-title {
+    margin-left: 11px;
+}
+
+.watch-expression-text-prompt-proxy {
+    margin-left: 12px;
+}
+
+.watch-expression.hovered .primitive-value {
+    background-color: #F0F0F0;
+}
+
+.watch-expression.hovered .primitive-value .watch-expression-title {
+    margin-right: 14px;
+}
+
+.watch-expression.hovered .section .header {
+    background-color: #F0F0F0;
+    padding-right: 14px;
+}