Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 905723004: Files.app: Rename a variable in drive_api_util.cc for more sanity. (Closed)

Created:
5 years, 10 months ago by Ben Kwa
Modified:
5 years, 10 months ago
Reviewers:
mtomasz, yoshiki
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Rename a variable in drive_api_util.cc for more sanity. BUG=453880 Committed: https://crrev.com/e9aa71290a8a0d05e385694d533a74b63cce7675 Cr-Commit-Position: refs/heads/master@{#315363}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/drive/drive_api_util.cc View 2 chunks +4 lines, -4 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
Ben Kwa
5 years, 10 months ago (2015-02-06 16:10:11 UTC) #2
yoshiki
lgtm
5 years, 10 months ago (2015-02-09 18:55:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905723004/1
5 years, 10 months ago (2015-02-09 19:24:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 19:27:31 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e9aa71290a8a0d05e385694d533a74b63cce7675 Cr-Commit-Position: refs/heads/master@{#315363}
5 years, 10 months ago (2015-02-09 19:28:20 UTC) #7
mtomasz
5 years, 10 months ago (2015-02-25 02:36:30 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/905723004/diff/1/chrome/browser/drive/drive_a...
File chrome/browser/drive/drive_api_util.cc (right):

https://codereview.chromium.org/905723004/diff/1/chrome/browser/drive/drive_a...
chrome/browser/drive/drive_api_util.cc:195: void
FileStreamMd5Digester::OnChunkRead(int bytesRead) {
nit: bytes_read.

Powered by Google App Engine
This is Rietveld 408576698