Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build_apprtc_appengine_app.py

Issue 905723002: Disabling AppRTC build on win. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/webrtc/webrtc.DEPS/
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build_apprtc_appengine_app.py
===================================================================
--- build_apprtc_appengine_app.py (revision 293976)
+++ build_apprtc_appengine_app.py (working copy)
@@ -55,6 +55,10 @@
return ('Missing grunt-cli in the apprtc checkout; did '
'npm install fail?')
+ if utils.GetPlatform() is 'win':
+ # https://github.com/webrtc/apprtc/issues/48
+ print 'grunt build is broken on win; cannot build apprtc'
+ return
utils.RunSubprocessWithRetry([node_bin, local_grunt_bin, 'build'])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698