Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 905703003: Instrumented libraries: drop liboverlay-scrollbar. (Closed)

Created:
5 years, 10 months ago by earthdok
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instrumented libraries: drop liboverlay-scrollbar. Chrome doesn't use overlay scrollbars. The only thing that we do with this library is attempt to initialize it (as part of gtk2+ init) which occasionally tries to read a missing settings schema and crashes. BUG=456205 TBR=glider@chromium.org NOTRY=true Committed: https://crrev.com/fa52c8105b87d7e9963e9ca7a346575b0f0cf24c Cr-Commit-Position: refs/heads/master@{#315361}

Patch Set 1 #

Patch Set 2 : fix syntax #

Patch Set 3 : build deps #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -22 lines) Patch
M third_party/instrumented_libraries/install-build-deps.sh View 1 2 2 chunks +2 lines, -2 lines 2 comments Download
M third_party/instrumented_libraries/instrumented_libraries.gyp View 2 chunks +0 lines, -11 lines 0 comments Download
M third_party/instrumented_libraries/patches/libgtk2.0-0.precise.diff View 1 1 chunk +11 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
earthdok
5 years, 10 months ago (2015-02-09 19:16:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905703003/40001
5 years, 10 months ago (2015-02-09 19:18:09 UTC) #3
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-09 19:19:08 UTC) #4
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/fa52c8105b87d7e9963e9ca7a346575b0f0cf24c Cr-Commit-Position: refs/heads/master@{#315361}
5 years, 10 months ago (2015-02-09 19:20:12 UTC) #5
Alexander Potapenko
lgtm https://codereview.chromium.org/905703003/diff/40001/third_party/instrumented_libraries/install-build-deps.sh File third_party/instrumented_libraries/install-build-deps.sh (right): https://codereview.chromium.org/905703003/diff/40001/third_party/instrumented_libraries/install-build-deps.sh#newcode72 third_party/instrumented_libraries/install-build-deps.sh:72: libsecret" This line seems unrelated to the change.
5 years, 10 months ago (2015-02-10 08:58:15 UTC) #6
earthdok
5 years, 10 months ago (2015-02-10 11:53:39 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/905703003/diff/40001/third_party/instrumented...
File third_party/instrumented_libraries/install-build-deps.sh (right):

https://codereview.chromium.org/905703003/diff/40001/third_party/instrumented...
third_party/instrumented_libraries/install-build-deps.sh:72: libsecret"
On 2015/02/10 08:58:15, Alexander Potapenko wrote:
> This line seems unrelated to the change.

It is.

Powered by Google App Engine
This is Rietveld 408576698