Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 905703002: Add KeyedServiceShutdownNotifier for classes that depend on keyed services but can't be keyed servi… (Closed)

Created:
5 years, 10 months ago by Bernhard Bauer
Modified:
5 years, 10 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add KeyedServiceShutdownNotifier for classes that depend on keyed services but can't be keyed services themselves. BUG=395391 Committed: https://crrev.com/76e4425f572bdbe42a8564c0ceb110c3b24db9f9 Cr-Commit-Position: refs/heads/master@{#315234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -0 lines) Patch
M components/keyed_service.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M components/keyed_service/content/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/keyed_service/content/browser_context_keyed_service_shutdown_notifier_factory.h View 1 chunk +35 lines, -0 lines 0 comments Download
A components/keyed_service/content/browser_context_keyed_service_shutdown_notifier_factory.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M components/keyed_service/core/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/keyed_service/core/keyed_service_shutdown_notifier.h View 1 chunk +39 lines, -0 lines 0 comments Download
A components/keyed_service/core/keyed_service_shutdown_notifier.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bernhard Bauer
Hi Elliot, PTAL at this CL and let me know what you think. For a ...
5 years, 10 months ago (2015-02-06 16:20:35 UTC) #2
Elliot Glaysher
i suppose this lgtm it feels more than a little hacky to put things that ...
5 years, 10 months ago (2015-02-06 20:59:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905703002/1
5 years, 10 months ago (2015-02-08 13:54:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-08 14:02:56 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-08 14:03:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76e4425f572bdbe42a8564c0ceb110c3b24db9f9
Cr-Commit-Position: refs/heads/master@{#315234}

Powered by Google App Engine
This is Rietveld 408576698