Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 905663002: Use network counting from webrtc for UMA. (Closed)

Created:
5 years, 10 months ago by guoweis_left_chromium
Modified:
5 years, 10 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use network counting from webrtc for UMA. Chrome passes each IP address in its own Network object. These IPv4Interfaces and IPv6Interfaces are really counting the number of IP addresses, not interfaces. To make these UMA accurate, a new stats struct is returned from WebRTC's MergeNetworkList which should control the grouping policy of IP addresses into network. BUG=413437 Committed: https://crrev.com/2b116774d45296e8ad76725bd762873a56760e5b Cr-Commit-Position: refs/heads/master@{#315409}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M content/renderer/p2p/ipc_network_manager.cc View 1 4 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
guoweis_left_chromium
PTAL.
5 years, 10 months ago (2015-02-06 21:48:50 UTC) #2
guoweis_left_chromium
On 2015/02/06 21:48:50, guoweis_chromium wrote: > PTAL. Ping.
5 years, 10 months ago (2015-02-09 18:40:28 UTC) #3
Sergey Ulanov
lgtm https://codereview.chromium.org/905663002/diff/1/content/renderer/p2p/ipc_network_manager.cc File content/renderer/p2p/ipc_network_manager.cc (right): https://codereview.chromium.org/905663002/diff/1/content/renderer/p2p/ipc_network_manager.cc#newcode126 content/renderer/p2p/ipc_network_manager.cc:126: if (changed) { remove {} here or add ...
5 years, 10 months ago (2015-02-09 19:23:59 UTC) #4
guoweis_left_chromium
On 2015/02/09 19:23:59, Sergey Ulanov wrote: > lgtm > > https://codereview.chromium.org/905663002/diff/1/content/renderer/p2p/ipc_network_manager.cc > File content/renderer/p2p/ipc_network_manager.cc (right): ...
5 years, 10 months ago (2015-02-09 20:44:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905663002/20001
5 years, 10 months ago (2015-02-09 20:45:40 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 22:27:14 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 22:27:44 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2b116774d45296e8ad76725bd762873a56760e5b
Cr-Commit-Position: refs/heads/master@{#315409}

Powered by Google App Engine
This is Rietveld 408576698