Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 905653003: Moved adding listeners on webview from load to constructor (Closed)

Created:
5 years, 10 months ago by Roman Sorokin (ftl)
Modified:
5 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved adding listeners on webview from load to constructor Current implementation causes same multiple listeners wait for an event after we load page several times. E.g. in ChromeOS: add user->cancel->add user. After login we get multiple identical messages. BUG=426316 TEST=manual Committed: https://crrev.com/823b2ac81df6cd3859462c32c370598120666676 Cr-Commit-Position: refs/heads/master@{#315286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -21 lines) Patch
M chrome/browser/resources/gaia_auth_host/authenticator.js View 3 chunks +25 lines, -21 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Roman Sorokin (ftl)
Xiyuan, please review
5 years, 10 months ago (2015-02-06 13:54:06 UTC) #2
xiyuan
lgtm Good catch. Neglected that .load could be called multiple times.
5 years, 10 months ago (2015-02-06 16:44:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905653003/1
5 years, 10 months ago (2015-02-09 07:18:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/56699)
5 years, 10 months ago (2015-02-09 07:42:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905653003/1
5 years, 10 months ago (2015-02-09 08:08:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/53460)
5 years, 10 months ago (2015-02-09 08:49:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905653003/1
5 years, 10 months ago (2015-02-09 11:39:06 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 13:28:46 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 13:29:12 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/823b2ac81df6cd3859462c32c370598120666676
Cr-Commit-Position: refs/heads/master@{#315286}

Powered by Google App Engine
This is Rietveld 408576698