Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: chrome/browser/prefs/pref_hash_store_impl.h

Issue 90563003: Fix a race condition in preference metric reporting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Also filter 'empty loads' as in new run or corrupted pref file scenarios. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/pref_hash_store.h ('k') | chrome/browser/prefs/pref_hash_store_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/pref_hash_store_impl.h
diff --git a/chrome/browser/prefs/pref_hash_store_impl.h b/chrome/browser/prefs/pref_hash_store_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..1d3f5817e32747b374b50ccdea74fb93d0222514
--- /dev/null
+++ b/chrome/browser/prefs/pref_hash_store_impl.h
@@ -0,0 +1,56 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PREFS_PREF_HASH_STORE_IMPL_H_
+#define CHROME_BROWSER_PREFS_PREF_HASH_STORE_IMPL_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/prefs/pref_hash_calculator.h"
+#include "chrome/browser/prefs/pref_hash_store.h"
+
+class PrefRegistrySimple;
+class PrefService;
+
+namespace base {
+class Value;
+} // namespace base
+
+// Implements PrefHashStoreImpl by storing preference hashes in a PrefService.
+class PrefHashStoreImpl : public PrefHashStore {
+ public:
+ // Constructs a PrefHashStoreImpl that calculates hashes using
+ // |seed| and |device_id| and stores them in |local_state|. Multiple hash
+ // stores can use the same |local_state| with distinct |hash_store_id|s.
+ //
+ // The same |seed|, |device_id|, and |hash_store_id| must be used to load and
+ // validate previously stored hashes in |local_state|.
+ //
+ // |local_state| must have previously been passed to |RegisterPrefs|.
+ PrefHashStoreImpl(const std::string& hash_store_id,
+ const std::string& seed,
+ const std::string& device_id,
+ PrefService* local_state);
+
+ // Registers required local state preferences.
+ static void RegisterPrefs(PrefRegistrySimple* registry);
+
+ // PrefHashStore implementation.
+ virtual ValueState CheckValue(const std::string& path,
+ const base::Value* value) const OVERRIDE;
+ virtual void StoreHash(const std::string& path,
+ const base::Value* value) OVERRIDE;
+
+ private:
+ std::string hash_store_id_;
+ PrefHashCalculator pref_hash_calculator_;
+ PrefService* local_state_;
+
+ DISALLOW_COPY_AND_ASSIGN(PrefHashStoreImpl);
+};
+
+#endif // CHROME_BROWSER_PREFS_PREF_HASH_STORE_IMPL_H_
« no previous file with comments | « chrome/browser/prefs/pref_hash_store.h ('k') | chrome/browser/prefs/pref_hash_store_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698