Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: chrome/browser/prefs/pref_hash_calculator.h

Issue 90563003: Fix a race condition in preference metric reporting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Also filter 'empty loads' as in new run or corrupted pref file scenarios. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/chrome_pref_service_factory.cc ('k') | chrome/browser/prefs/pref_hash_calculator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/pref_hash_calculator.h
diff --git a/chrome/browser/prefs/pref_hash_calculator.h b/chrome/browser/prefs/pref_hash_calculator.h
new file mode 100644
index 0000000000000000000000000000000000000000..6f0fd851790c341d8baae1241f4f27d427fa3513
--- /dev/null
+++ b/chrome/browser/prefs/pref_hash_calculator.h
@@ -0,0 +1,53 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PREFS_PREF_HASH_CALCULATOR_H_
+#define CHROME_BROWSER_PREFS_PREF_HASH_CALCULATOR_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+
+namespace base {
+class Value;
+} // namespace base
+
+// Calculates and validates preference value hashes.
+class PrefHashCalculator {
+ public:
+ enum ValidationResult {
+ INVALID,
+ VALID,
+ VALID_LEGACY,
+ };
+
+ // Constructs a PrefHashCalculator using |seed| and |device_id|. The same
+ // parameters must be used in order to successfully validate generated hashes.
+ // |device_id| may be empty.
+ PrefHashCalculator(const std::string& seed, const std::string& device_id);
+
+ // Calculates a hash value for the supplied preference |path| and |value|.
+ // |value| may be null if the preference has no value.
+ std::string Calculate(const std::string& path, const base::Value* value)
+ const;
+
+ // Validates the provided preference hash using current and legacy hashing
+ // algorithms.
+ ValidationResult Validate(const std::string& path,
+ const base::Value* value,
+ const std::string& hash) const;
+
+ private:
+ // Calculate a hash using a deprecated hash algorithm. For validating old
+ // hashes during migration.
+ std::string CalculateLegacyHash(const std::string& path,
+ const base::Value* value) const;
+
+ std::string seed_;
+ std::string device_id_;
+
+ DISALLOW_COPY_AND_ASSIGN(PrefHashCalculator);
+};
+
+#endif // CHROME_BROWSER_PREFS_PREF_HASH_CALCULATOR_H_
« no previous file with comments | « chrome/browser/prefs/chrome_pref_service_factory.cc ('k') | chrome/browser/prefs/pref_hash_calculator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698