chrome/browser/prefs/synced_pref_change_registrar.h - Issue 90563003: Fix a race condition in preference metric reporting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/synced_pref_change_registrar.h

Issue 90563003: Fix a race condition in preference metric reporting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Respond to Gab's comments. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prefs/synced_pref_change_registrar.h

diff --git a/chrome/browser/prefs/synced_pref_change_registrar.h b/chrome/browser/prefs/synced_pref_change_registrar.h

index 7cadd0a7457c009a98c3991b8c3805fac3f91b36..635623b17f30d1e669bf0d2a241edd869b75b843 100644

--- a/chrome/browser/prefs/synced_pref_change_registrar.h

+++ b/chrome/browser/prefs/synced_pref_change_registrar.h

@@ -9,9 +9,10 @@

#include <string>

#include "base/callback.h"

-#include "chrome/browser/prefs/pref_service_syncable.h"

#include "chrome/browser/prefs/synced_pref_observer.h"

+class PrefServiceSyncable;

// Manages the registration of one or more SyncedPrefObservers on a

// PrefServiceSyncable. This is modeled after base::PrefChangeRegistrar, and

// it should be used whenever it's necessary to determine whether a pref change