Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: chrome/browser/prefs/pref_hash_calculator.h

Issue 90563003: Fix a race condition in preference metric reporting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/pref_hash_calculator.h
diff --git a/chrome/browser/prefs/pref_hash_calculator.h b/chrome/browser/prefs/pref_hash_calculator.h
new file mode 100644
index 0000000000000000000000000000000000000000..1a54e51d6065b8d51da20ab2767c84ba897675ee
--- /dev/null
+++ b/chrome/browser/prefs/pref_hash_calculator.h
@@ -0,0 +1,42 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PREFS_PREF_HASH_CALCULATOR
+#define CHROME_BROWSER_PREFS_PREF_HASH_CALCULATOR
+
+#include <string>
+
+namespace base {
+class Value;
+} // namespace base
+
+// Calculates and validates preference value hashes.
+// This class is intentionally copy-constructable.
+class PrefHashCalculator {
+ public:
+ enum ValidationResult {
+ INVALID,
+ VALID,
+ VALID_LEGACY
+ };
+
+ // Constructs a PrefHashCalculator using |seed|. The same seed must be used in
+ // order to successfully validate generated hashes.
+ explicit PrefHashCalculator(const std::string& seed);
+
+ // Calculates a hash value for the supplied preference path and value. |value|
+ // may be null if the preference has no value.
+ std::string Calculate(const std::string& path, const base::Value* value);
+
+ // Validates the provided preference hash using current and legacy hashing
+ // algorithms.
+ ValidationResult Validate(const std::string& path,
+ const base::Value* value,
+ const std::string& hash);
+
+ private:
+ std::string seed_;
+};
+
+#endif // CHROME_BROWSER_PREFS_PREF_HASH_CALCULATOR

Powered by Google App Engine
This is Rietveld 408576698