Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: chrome/browser/prefs/browser_prefs.cc

Issue 90563003: Fix a race condition in preference metric reporting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments, tidying. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prefs/browser_prefs.h" 5 #include "chrome/browser/prefs/browser_prefs.h"
6 6
7 #include "apps/prefs.h" 7 #include "apps/prefs.h"
8 #include "base/debug/trace_event.h" 8 #include "base/debug/trace_event.h"
9 #include "base/prefs/pref_registry_simple.h" 9 #include "base/prefs/pref_registry_simple.h"
10 #include "base/prefs/pref_service.h" 10 #include "base/prefs/pref_service.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 #include "chrome/browser/net/pref_proxy_config_tracker_impl.h" 47 #include "chrome/browser/net/pref_proxy_config_tracker_impl.h"
48 #include "chrome/browser/net/ssl_config_service_manager.h" 48 #include "chrome/browser/net/ssl_config_service_manager.h"
49 #include "chrome/browser/network_time/network_time_service.h" 49 #include "chrome/browser/network_time/network_time_service.h"
50 #include "chrome/browser/notifications/desktop_notification_service.h" 50 #include "chrome/browser/notifications/desktop_notification_service.h"
51 #include "chrome/browser/notifications/notification_prefs_manager.h" 51 #include "chrome/browser/notifications/notification_prefs_manager.h"
52 #include "chrome/browser/password_manager/password_generation_manager.h" 52 #include "chrome/browser/password_manager/password_generation_manager.h"
53 #include "chrome/browser/password_manager/password_manager.h" 53 #include "chrome/browser/password_manager/password_manager.h"
54 #include "chrome/browser/pepper_flash_settings_manager.h" 54 #include "chrome/browser/pepper_flash_settings_manager.h"
55 #include "chrome/browser/plugins/plugin_finder.h" 55 #include "chrome/browser/plugins/plugin_finder.h"
56 #include "chrome/browser/prefs/incognito_mode_prefs.h" 56 #include "chrome/browser/prefs/incognito_mode_prefs.h"
57 #include "chrome/browser/prefs/pref_metrics_service.h" 57 #include "chrome/browser/prefs/pref_hash_store_impl.h"
58 #include "chrome/browser/prefs/pref_service_syncable.h" 58 #include "chrome/browser/prefs/pref_service_syncable.h"
59 #include "chrome/browser/prefs/session_startup_pref.h" 59 #include "chrome/browser/prefs/session_startup_pref.h"
60 #include "chrome/browser/printing/cloud_print/cloud_print_url.h" 60 #include "chrome/browser/printing/cloud_print/cloud_print_url.h"
61 #include "chrome/browser/printing/print_dialog_cloud.h" 61 #include "chrome/browser/printing/print_dialog_cloud.h"
62 #include "chrome/browser/profiles/chrome_version_service.h" 62 #include "chrome/browser/profiles/chrome_version_service.h"
63 #include "chrome/browser/profiles/profile.h" 63 #include "chrome/browser/profiles/profile.h"
64 #include "chrome/browser/profiles/profile_impl.h" 64 #include "chrome/browser/profiles/profile_impl.h"
65 #include "chrome/browser/profiles/profile_info_cache.h" 65 #include "chrome/browser/profiles/profile_info_cache.h"
66 #include "chrome/browser/profiles/profiles_state.h" 66 #include "chrome/browser/profiles/profiles_state.h"
67 #include "chrome/browser/renderer_host/pepper/device_id_fetcher.h" 67 #include "chrome/browser/renderer_host/pepper/device_id_fetcher.h"
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 FlagsUI::RegisterPrefs(registry); 223 FlagsUI::RegisterPrefs(registry);
224 geolocation::RegisterPrefs(registry); 224 geolocation::RegisterPrefs(registry);
225 GLStringManager::RegisterPrefs(registry); 225 GLStringManager::RegisterPrefs(registry);
226 GpuModeManager::RegisterPrefs(registry); 226 GpuModeManager::RegisterPrefs(registry);
227 IntranetRedirectDetector::RegisterPrefs(registry); 227 IntranetRedirectDetector::RegisterPrefs(registry);
228 IOThread::RegisterPrefs(registry); 228 IOThread::RegisterPrefs(registry);
229 KeywordEditorController::RegisterPrefs(registry); 229 KeywordEditorController::RegisterPrefs(registry);
230 MetricsLog::RegisterPrefs(registry); 230 MetricsLog::RegisterPrefs(registry);
231 MetricsService::RegisterPrefs(registry); 231 MetricsService::RegisterPrefs(registry);
232 metrics::CachingPermutedEntropyProvider::RegisterPrefs(registry); 232 metrics::CachingPermutedEntropyProvider::RegisterPrefs(registry);
233 PrefMetricsService::RegisterPrefs(registry); 233 PrefHashStoreImpl::RegisterPrefs(registry);
234 PrefProxyConfigTrackerImpl::RegisterPrefs(registry); 234 PrefProxyConfigTrackerImpl::RegisterPrefs(registry);
235 ProfileInfoCache::RegisterPrefs(registry); 235 ProfileInfoCache::RegisterPrefs(registry);
236 profiles::RegisterPrefs(registry); 236 profiles::RegisterPrefs(registry);
237 PromoResourceService::RegisterPrefs(registry); 237 PromoResourceService::RegisterPrefs(registry);
238 RegisterPrefsForRecoveryComponent(registry); 238 RegisterPrefsForRecoveryComponent(registry);
239 RegisterScreenshotPrefs(registry); 239 RegisterScreenshotPrefs(registry);
240 SigninManagerFactory::RegisterPrefs(registry); 240 SigninManagerFactory::RegisterPrefs(registry);
241 SSLConfigServiceManager::RegisterPrefs(registry); 241 SSLConfigServiceManager::RegisterPrefs(registry);
242 UpgradeDetector::RegisterPrefs(registry); 242 UpgradeDetector::RegisterPrefs(registry);
243 WebCacheManager::RegisterPrefs(registry); 243 WebCacheManager::RegisterPrefs(registry);
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
557 } 557 }
558 local_state->ClearPref(prefs::kLastPromptedGoogleURL); 558 local_state->ClearPref(prefs::kLastPromptedGoogleURL);
559 559
560 current_version |= GOOGLE_URL_TRACKER_PREFS; 560 current_version |= GOOGLE_URL_TRACKER_PREFS;
561 local_state->SetInteger(prefs::kMultipleProfilePrefMigration, 561 local_state->SetInteger(prefs::kMultipleProfilePrefMigration,
562 current_version); 562 current_version);
563 } 563 }
564 } 564 }
565 565
566 } // namespace chrome 566 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698