chrome/browser/prefs/pref_change_reporter.h - Issue 90563003: Fix a race condition in preference metric reporting.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/prefs/pref_change_reporter.h

Issue 90563003: Fix a race condition in preference metric reporting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_PREFS_PREF_CHANGE_REPORTER_H_

	6 #define CHROME_BROWSER_PREFS_PREF_CHANGE_REPORTER_H_

	7

	8 #include "base/memory/scoped_ptr.h"

	9

	10 class JsonPrefStore;

	11 class PrefHashStore;

	12

	13 // Enables UMA reporting of tracked preference changes in \|pref_store\|, using

	14 // \|pref_hash_store\|. Must be called before \|pref_store\| has begun loading.

	15 // \|pref_hash_store\| will be destroyed when \|pref_store\| is destroyed.

	16 //

	17 void ReportPrefStoreChangesToUMA(JsonPrefStore* pref_store,
	gab 2013/11/27 23:43:27 Change this name to something more generic as this Change this name to something more generic as this could be used in the future to do more than UMA.
	18 scoped_ptr<PrefHashStore> pref_hash_store);

	19

	20 #endif // CHROME_BROWSER_PREFS_PREF_CHANGE_REPORTER_H_

OLD	NEW