Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: mojo/public/interfaces/application/application.mojom

Issue 905583002: Pass the final URL an app was loaded from to the app in Initialize(). (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/application/lib/application_test_base.cc ('k') | shell/application_manager/shell_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/interfaces/application/application.mojom
diff --git a/mojo/public/interfaces/application/application.mojom b/mojo/public/interfaces/application/application.mojom
index cffcb1fc7606aa30ea59360f86f8bd31dd4e7537..7e8c49362715e107cfb3d3e02a4ea8b644a391f6 100644
--- a/mojo/public/interfaces/application/application.mojom
+++ b/mojo/public/interfaces/application/application.mojom
@@ -13,8 +13,9 @@ import "mojo/public/interfaces/application/shell.mojom";
interface Application {
// Initializes the application with the specified arguments. This method is
// guaranteed to be called before any other method is called, and will only be
- // called once.
- Initialize(Shell shell, array<string>? args);
+ // called once. The |url| parameter is the final url the application was found
+ // at, after all redirects and resolutions.
+ Initialize(Shell shell, string url, array<string>? args);
sky 2015/02/05 23:41:22 Is there a reason we don't want to pass the url as
Aaron Boodman 2015/02/05 23:45:27 I guess since we don't know the shape of the sandb
sky 2015/02/05 23:49:51 Doesn't the array<string> provide you with more fl
Aaron Boodman 2015/02/06 00:11:54 AFAIK, after release, it would not be possible to
Aaron Boodman 2015/02/06 00:27:55 With a moment more thought (and double checking wi
// Called when another application (identified by |requestor_url|) attempts to
// open a connection to this application.
« no previous file with comments | « mojo/public/cpp/application/lib/application_test_base.cc ('k') | shell/application_manager/shell_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698