Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: remoting/webapp/build-webapp.py

Issue 905553002: [Chromoting] Pass list of locale files into build-webapp in a single file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/build-webapp.py
diff --git a/remoting/webapp/build-webapp.py b/remoting/webapp/build-webapp.py
index 9868b6c142ff99b04df5fb8c5f1c8ca2d3dbf09c..f98565f74ef08eed52ec0b8392bf2c38225c3847 100755
--- a/remoting/webapp/build-webapp.py
+++ b/remoting/webapp/build-webapp.py
@@ -375,6 +375,7 @@ def main():
'--app_capabilities <capabilities...> '
'[--appid <appid>] '
'[--locales <locales...>] '
Jamie 2015/02/05 19:26:20 Do we still need to support --locales? If not then
garykac 2015/02/06 02:13:35 Done.
+ '[--locale_file <locale-file>] '
Jamie 2015/02/05 19:26:20 s/locale/locales/g (it contains a list of all loca
garykac 2015/02/06 02:13:35 Done.
'[--jinja_paths <paths...>] '
'[--service_environment <service_environment>]')
return 1
@@ -382,6 +383,7 @@ def main():
arg_type = ''
files = []
locales = []
+ locale_file = ''
jinja_paths = []
app_id = None
app_name = None
@@ -391,6 +393,7 @@ def main():
for arg in sys.argv[7:]:
if arg in ['--locales',
+ '--locale_file',
'--jinja_paths',
'--appid',
'--app_name',
@@ -400,6 +403,9 @@ def main():
arg_type = arg
elif arg_type == '--locales':
locales.append(arg)
+ elif arg_type == '--locale_file':
+ locale_file = arg
+ arg_type = ''
elif arg_type == '--jinja_paths':
jinja_paths.append(arg)
elif arg_type == '--appid':
@@ -419,6 +425,13 @@ def main():
else:
files.append(arg)
+ # If the locale files were specified in a listfile, then load them into
+ # the locales array.
+ if locale_file:
+ with open(locale_file) as input:
+ for s in input:
+ locales.append(s.rstrip())
+
return buildWebApp(sys.argv[1], sys.argv[2], sys.argv[3], sys.argv[4],
sys.argv[5], sys.argv[6], app_id, app_name,
app_description, app_capabilities, files, locales,
« remoting/tools/build/remoting_localize.py ('K') | « remoting/tools/build/remoting_localize.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698