Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Issue 905543002: [OSX] Fix alignment for permission bubble. (Closed)

Created:
5 years, 10 months ago by groby-ooo-7-16
Modified:
5 years, 10 months ago
Reviewers:
felt
CC:
chromium-reviews, egm
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[OSX] Fix alignment for permission bubble. Spacing adjusted according to spec: http://goo.gl/vGZOmm See screenshot(fixed version) at http://imgur.com/xptLuWK BUG=452940 R=felt@chromium.org Committed: https://crrev.com/1fb20a07d1ba0abfbdb20ef3582318f2f6910af7 Cr-Commit-Position: refs/heads/master@{#314863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm View 4 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
groby-ooo-7-16
PTAL
5 years, 10 months ago (2015-02-05 18:18:21 UTC) #1
felt
lgtm
5 years, 10 months ago (2015-02-05 18:42:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905543002/1
5 years, 10 months ago (2015-02-05 19:11:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 20:11:05 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 20:11:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fb20a07d1ba0abfbdb20ef3582318f2f6910af7
Cr-Commit-Position: refs/heads/master@{#314863}

Powered by Google App Engine
This is Rietveld 408576698