Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: chrome/browser/chromeos/platform_keys/platform_keys_nss.cc

Issue 905523002: platformKeys: Add per-extension sign permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pks_sign_task
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
diff --git a/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc b/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
index 978f1159a37f207e3f423299d7f192ba427e5813..e426bd2ee321d21edbc514f19d0cd887c0274015 100644
--- a/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
+++ b/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
@@ -776,12 +776,15 @@ void SelectClientCertificates(const ClientCertificateRequest& request,
} // namespace subtle
+std::string GetSubjectPublicKeyInfo(
+ const scoped_refptr<net::X509Certificate>& certificate) {
+ const SECItem& spki_der = certificate->os_cert_handle()->derPublicKey;
+ return std::string(spki_der.data, spki_der.data + spki_der.len);
+}
+
bool GetPublicKey(const scoped_refptr<net::X509Certificate>& certificate,
- std::string* public_key_spki_der,
net::X509Certificate::PublicKeyType* key_type,
size_t* key_size_bits) {
- const SECItem& spki_der = certificate->os_cert_handle()->derPublicKey;
-
net::X509Certificate::PublicKeyType key_type_tmp =
net::X509Certificate::kPublicKeyTypeUnknown;
size_t key_size_bits_tmp = 0;
@@ -809,10 +812,8 @@ bool GetPublicKey(const scoped_refptr<net::X509Certificate>& certificate,
return false;
}
- public_key_spki_der->assign(spki_der.data, spki_der.data + spki_der.len);
*key_type = key_type_tmp;
*key_size_bits = key_size_bits_tmp;
-
return true;
}

Powered by Google App Engine
This is Rietveld 408576698