Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 905503003: Remove unused methods from URLRequest. (Closed)

Created:
5 years, 10 months ago by mmenke
Modified:
5 years, 10 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused methods from URLRequest. Remove methods to get/set headers by "ID", which were never implemented and have existed since initial commit. Also remove GetAllResponseHeaders, which returns all response headers in a single string with NULL characters between headers. Shockingly, nothing is using this method. BUG=455744 Committed: https://crrev.com/90948ab7b3ced4cd727f92980de46eff6fdd69b2 Cr-Commit-Position: refs/heads/master@{#314852}

Patch Set 1 #

Patch Set 2 : Remove more stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -102 lines) Patch
D net/http/http_atom_list.h View 1 chunk +0 lines, -61 lines 0 comments Download
M net/net.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request.h View 1 3 chunks +4 lines, -20 lines 0 comments Download
M net/url_request/url_request.cc View 1 3 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mmenke
Mind reviewing this (And a couple CLs like it)? Think you're the only network stack ...
5 years, 10 months ago (2015-02-05 17:11:20 UTC) #2
davidben
lgtm! > Think you're the only network stack team member other than I who's touched ...
5 years, 10 months ago (2015-02-05 18:22:12 UTC) #3
davidben
lgtm! > Think you're the only network stack team member other than I who's touched ...
5 years, 10 months ago (2015-02-05 18:22:13 UTC) #4
mmenke
On 2015/02/05 18:22:13, David Benjamin wrote: > lgtm! > > > Think you're the only ...
5 years, 10 months ago (2015-02-05 18:24:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905503003/20001
5 years, 10 months ago (2015-02-05 18:25:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 19:21:25 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 19:22:36 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/90948ab7b3ced4cd727f92980de46eff6fdd69b2
Cr-Commit-Position: refs/heads/master@{#314852}

Powered by Google App Engine
This is Rietveld 408576698