Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 905473003: Fix Code::VerifyEmbeddedObjects. (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Code::VerifyEmbeddedObjects. BUG= Committed: https://crrev.com/015e7865a09121dc0ceda9e88e026ebd3569538e Cr-Commit-Position: refs/heads/master@{#26465}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/objects-debug.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
ulan
Jakob, thanks for catching the bug! Here is the fix.
5 years, 10 months ago (2015-02-05 13:41:04 UTC) #2
Jakob Kummerow
LGTM, thanks for the quick fix!
5 years, 10 months ago (2015-02-05 13:41:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905473003/1
5 years, 10 months ago (2015-02-05 13:42:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 15:25:33 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 15:25:42 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/015e7865a09121dc0ceda9e88e026ebd3569538e
Cr-Commit-Position: refs/heads/master@{#26465}

Powered by Google App Engine
This is Rietveld 408576698