Update ScrollAnimator's copy of the layer dimensions after layout.

Update ScrollAnimator's copy of the layer dimensions after layout.

BUG=575
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189681

[skobes, 2015-02-06 02:53:00]

skobes@chromium.org changed reviewers:
+ ajuma@chromium.org, vollick@chromium.org

[skobes, 2015-02-06 02:53:01]

(vollick for platform/OWNERS)

This is needed for http://crrev.com/882813005, otherwise
ScrollAnimatorNone::PerAxisData::m_visibleLength is 0, which screws up the
computations in updateDataFromParameters.  The visible effect is that the
animation is way slower than it should be.

I will also update the test in http://crrev.com/882813005 to sanity check that
the animation completes in a reasonable time.

[skobes, 2015-02-06 02:55:02]

On 2015/02/06 02:53:01, skobes wrote:
> (vollick for platform/OWNERS)
> 
> This is needed for http://crrev.com/882813005, otherwise
> ScrollAnimatorNone::PerAxisData::m_visibleLength is 0, which screws up the
> computations in updateDataFromParameters.  The visible effect is that the
> animation is way slower than it should be.

(This probably also contributed to the impact of http://crbug.com/383946.)

[ajuma, 2015-02-06 14:41:13]

https://codereview.chromium.org/905463007/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderLayer.cpp (right):

https://codereview.chromium.org/905463007/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderLayer.cpp:263:
m_scrollableArea->scrollAnimator()->contentsResized();
Calling scrollAnimator() will construct an animator if we don't already have
one. Unless that's really the desired behavior, it'd be better to call
existingScrollAnimator and null-check the result.

https://codereview.chromium.org/905463007/diff/1/Source/platform/scroll/Scrol...
File Source/platform/scroll/ScrollAnimator.h (right):

https://codereview.chromium.org/905463007/diff/1/Source/platform/scroll/Scrol...
Source/platform/scroll/ScrollAnimator.h:85: virtual void contentsResized() { }
ScrollAnimatorMac also overrides this, so ScrollAnimatorMac::contentsResized
also needs to be changed to non-const.

[ajuma, 2015-02-06 14:47:33]

lgtm with those nits addressed.

[skobes, 2015-02-06 17:16:42]

New patchsets have been uploaded after l-g-t-m from ajuma@chromium.org

[skobes, 2015-02-06 17:57:54]

I didn't realize ScrollAnimatorMac had an override of contentsResized, and I'm
not sure we want to call it on every layout.  I've added a new method instead,
PTAL.

[ajuma, 2015-02-06 18:01:34]

On 2015/02/06 17:57:54, skobes wrote:
> I didn't realize ScrollAnimatorMac had an override of contentsResized, and I'm
> not sure we want to call it on every layout.  I've added a new method instead,
> PTAL.

still lgtm

[skobes, 2015-02-06 18:14:38]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2015-02-06 18:15:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/905463007/60001

[commit-bot: I haz the power, 2015-02-06 18:22:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-06 18:22:23]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/2...)

[Ian Vollick, 2015-02-06 20:34:48]

On 2015/02/06 18:22:23, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   blink_presubmit on tryserver.blink (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/2...)

lgtm

[Ian Vollick, 2015-02-06 20:35:01]

The CQ bit was checked by vollick@chromium.org

[commit-bot: I haz the power, 2015-02-06 20:36:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/905463007/60001

[commit-bot: I haz the power, 2015-02-06 20:39:46]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189681