Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 905433003: webui: remove FocusManager.disableMouseFocusOnButtons(). (Closed)

Created:
5 years, 10 months ago by Dan Beam
Modified:
5 years, 10 months ago
Reviewers:
tkent
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, extensions-reviews_chromium.org, dbeam+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, arv (Not doing code reviews), dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webui: remove FocusManager.disableMouseFocusOnButtons(). It seems to be unnecessary now (tested against bugs: 256127, 256124) and messes with focus order (i.e. click on a <button>, press tab -> should go to next focusable item on the page but instead starts at top). In general I'd also just like to match the rest of the web if possible. R=tkent@chromium.org BUG=none TEST=manual Committed: https://crrev.com/68673f7785ea1f48017b1d13c74aa80702332c88 Cr-Commit-Position: refs/heads/master@{#315251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -43 lines) Patch
M chrome/browser/resources/extensions/extension_focus_manager.js View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/help/help.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/ntp4/new_tab.js View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/options.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/uber/uber_frame.js View 1 chunk +0 lines, -1 line 0 comments Download
M ui/webui/resources/js/cr/ui/focus_manager.js View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dan Beam
5 years, 10 months ago (2015-02-06 21:22:43 UTC) #1
tkent
lgtm. Let's try this.
5 years, 10 months ago (2015-02-08 23:53:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905433003/1
5 years, 10 months ago (2015-02-09 00:37:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 00:41:06 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 00:41:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68673f7785ea1f48017b1d13c74aa80702332c88
Cr-Commit-Position: refs/heads/master@{#315251}

Powered by Google App Engine
This is Rietveld 408576698