src/utils.h - Issue 905383003: Fix issue when compiling with gcc 4.6.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils.h

Issue 905383003: Fix issue when compiling with gcc 4.6. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils.h

diff --git a/src/utils.h b/src/utils.h

index 6a43c77228c217e0170a00b2dc17cb7c11240af5..7c3f8707b0ec8aa87efb36acd8d2f3cef09d3688 100644

--- a/src/utils.h

+++ b/src/utils.h

@@ -1435,7 +1435,7 @@ void CopyCharsUnsigned(uint8_t* dest, const uint8_t* src, size_t chars) {

void CopyCharsUnsigned(uint16_t* dest, const uint8_t* src, size_t chars) {

- if (chars >= kMinComplexConvertMemCopy) {

+ if (chars >= static_cast<unsigned>(kMinComplexConvertMemCopy)) {

jochen (gone - plz use gerrit) 2015/02/10 10:38:35 nit. why not static_cast<size_t> ?

Rodolph Perfetta (ARM) 2015/02/11 16:28:58 Done.

MemCopyUint16Uint8(dest, src, chars);

} else {

MemCopyUint16Uint8Wrapper(dest, src, chars);

« no previous file with comments | « no previous file | no next file » | no next file with comments »