Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 905383003: Fix issue when compiling with gcc 4.6. (Closed)

Created:
5 years, 10 months ago by Rodolph Perfetta (ARM)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix issue when compiling with gcc 4.6. BUG= Committed: https://crrev.com/59cf171d3d8a6406c78e1bfe1e3df2409ab00d14 Cr-Commit-Position: refs/heads/master@{#26592}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/utils.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Rodolph Perfetta (ARM)
This fixes the build for some of our old hardware.
5 years, 10 months ago (2015-02-09 17:25:23 UTC) #2
jochen (gone - plz use gerrit)
lgtm with comment https://codereview.chromium.org/905383003/diff/1/src/utils.h File src/utils.h (right): https://codereview.chromium.org/905383003/diff/1/src/utils.h#newcode1438 src/utils.h:1438: if (chars >= static_cast<unsigned>(kMinComplexConvertMemCopy)) { nit. ...
5 years, 10 months ago (2015-02-10 10:38:35 UTC) #3
Rodolph Perfetta (ARM)
https://codereview.chromium.org/905383003/diff/1/src/utils.h File src/utils.h (right): https://codereview.chromium.org/905383003/diff/1/src/utils.h#newcode1438 src/utils.h:1438: if (chars >= static_cast<unsigned>(kMinComplexConvertMemCopy)) { On 2015/02/10 10:38:35, jochen ...
5 years, 10 months ago (2015-02-11 16:28:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905383003/20001
5 years, 10 months ago (2015-02-11 16:30:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-11 16:52:25 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 16:52:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/59cf171d3d8a6406c78e1bfe1e3df2409ab00d14
Cr-Commit-Position: refs/heads/master@{#26592}

Powered by Google App Engine
This is Rietveld 408576698