Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 905243005: Disable flaky test Pixel.Canvas2DRedBox. (Closed)

Created:
5 years, 10 months ago by jiayl
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, Ryan Hamilton, bajones, Zhenyao Mo, David Yen, Justin Novosad
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky test Pixel.Canvas2DRedBox. TBR=kbr@chromium.org NOTRY=true BUG=456928 Committed: https://crrev.com/67aee2177f9d64877dec00c41beff6974e23db88 Cr-Commit-Position: refs/heads/master@{#315388}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/test/gpu/page_sets/pixel_tests.py View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jiayl
Not sure if this is the best way to disable this test.PTAL
5 years, 10 months ago (2015-02-09 20:41:00 UTC) #2
jiayl
5 years, 10 months ago (2015-02-09 20:41:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905243005/1
5 years, 10 months ago (2015-02-09 20:59:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 21:00:35 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/67aee2177f9d64877dec00c41beff6974e23db88 Cr-Commit-Position: refs/heads/master@{#315388}
5 years, 10 months ago (2015-02-09 21:01:35 UTC) #7
Ken Russell (switch to Gerrit)
5 years, 10 months ago (2015-02-10 16:18:32 UTC) #8
Message was sent while issue was closed. 
This isn't good -- as I mentioned on http://crbug.com/456928 , it's the
trace_test that's flaky, and it's a problem that it's reusing the pixel_tests'
page set and therefore its test names, making it impossible to selectively
disable the trace_test.

Please work with dyen, bajones and zmo to disable the trace_test specifically
instead, and re-enable this test. As it stands, there is now a gap in the
end-to-end testing of accelerated 2D canvas.

Powered by Google App Engine
This is Rietveld 408576698