Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 905223002: Revert of [Chromoting] Remove wildcard ('*') from remoting_all target. (Closed)

Created:
5 years, 10 months ago by bshe
Modified:
5 years, 10 months ago
Reviewers:
vapier, garykac, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromoting] Remove wildcard ('*') from remoting_all target. (patchset #8 id:140001 of https://codereview.chromium.org/896743004/) Reason for revert: It cause ChromiumOS.Chromium and PFQ bots to fail. The reason might because chroot didn't have "dpkg-architecture" command. The correct solution might be add "dpkg-architecture" command to chroot. But this CL currently break PFQ and a bunch of bots. So revert it for immediate fix. See crbug.com/456491 Original issue's description: > [Chromoting] Remove wildcard ('*') from remoting_all target. > > Support for the wildcard is going away in GN, so this helps prepare for the transition away from GYP. > > This cl adds dummy targets so that that logic for when the proper targets should be build can be kept in the platform-specific files. > > Some of the conditions in the host gyp files needed to be restructured so that the dummy targets would be defined only when necessary. The updated conditions caused a lot of lines to be re-indented, but the target definitions are the same (except for the new dummy targets). > > BUG= > > Committed: https://crrev.com/9fb75ed89c0ae4ced679576f9cf030cc8c30e928 > Cr-Commit-Position: refs/heads/master@{#315150} TBR=kelvinp@chromium.org,garykac@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/c29be3bc08f24d515d07547570e5d0d7f1a10ff3 Cr-Commit-Position: refs/heads/master@{#315261}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+892 lines, -987 lines) Patch
M remoting/remoting_all.gyp View 1 chunk +2 lines, -64 lines 0 comments Download
D remoting/remoting_enable.gypi View 1 chunk +0 lines, -24 lines 0 comments Download
M remoting/remoting_host.gypi View 4 chunks +162 lines, -162 lines 0 comments Download
M remoting/remoting_host_linux.gypi View 4 chunks +19 lines, -28 lines 0 comments Download
M remoting/remoting_host_mac.gypi View 1 chunk +230 lines, -226 lines 0 comments Download
M remoting/remoting_host_win.gypi View 2 chunks +469 lines, -480 lines 0 comments Download
M remoting/remoting_test.gypi View 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
bshe
Created Revert of [Chromoting] Remove wildcard ('*') from remoting_all target.
5 years, 10 months ago (2015-02-09 03:23:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905223002/1
5 years, 10 months ago (2015-02-09 03:23:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 03:24:16 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c29be3bc08f24d515d07547570e5d0d7f1a10ff3 Cr-Commit-Position: refs/heads/master@{#315261}
5 years, 10 months ago (2015-02-09 03:24:47 UTC) #4
vapier
fwiw, i don't think adding dpkg-architecture is reasonable. the build system shouldn't require Debian tools.
5 years, 10 months ago (2015-02-09 14:33:28 UTC) #6
kelvinp
5 years, 10 months ago (2015-02-09 21:37:24 UTC) #7
Message was sent while issue was closed.
On 2015/02/09 14:33:28, vapier wrote:
> fwiw, i don't think adding dpkg-architecture is reasonable.  the build system
> shouldn't require Debian tools.

Looks like after the CL, we are building the host installer on Chrome-OS, which
we shouldn't need to.
I can take a look.

Powered by Google App Engine
This is Rietveld 408576698