Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 9052007: Create an API around WorkerService that chrome consumes. Rename the existing WorkerService to Wor... (Closed)

Created:
8 years, 12 months ago by jam
Modified:
8 years, 12 months ago
CC:
chromium-reviews, yoshiki+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Create an API around WorkerService that chrome consumes. Rename the existing WorkerService to WorkerServiceImpl and put it in the content namespace while at it. Also move WorkerServiceObserver to the public directory and into the content namespace. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116007

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -849 lines) Patch
M chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/debugger/devtools_sanity_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_worker_resource_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/task_manager/task_manager_worker_resource_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/workers_ui.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/debugger/worker_devtools_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/debugger/worker_devtools_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/debugger/worker_devtools_message_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/resource_request_details.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/worker_host/worker_message_filter.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M content/browser/worker_host/worker_process_host.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 6 chunks +12 lines, -9 lines 0 comments Download
D content/browser/worker_host/worker_service.h View 1 chunk +0 lines, -149 lines 0 comments Download
D content/browser/worker_host/worker_service.cc View 1 chunk +0 lines, -559 lines 0 comments Download
A + content/browser/worker_host/worker_service_impl.h View 5 chunks +23 lines, -22 lines 0 comments Download
A + content/browser/worker_host/worker_service_impl.cc View 20 chunks +47 lines, -42 lines 0 comments Download
D content/browser/worker_host/worker_service_observer.h View 1 chunk +0 lines, -27 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +4 lines, -3 lines 0 comments Download
A content/public/browser/worker_service.h View 1 chunk +31 lines, -0 lines 0 comments Download
A + content/public/browser/worker_service_observer.h View 2 chunks +9 lines, -6 lines 0 comments Download
M content/worker/test/worker_uitest.cc View 6 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
8 years, 12 months ago (2011-12-29 23:10:21 UTC) #1
Dmitry Lomov (no reviews)
I see some compile failures on linux_rel and win_rel
8 years, 12 months ago (2011-12-29 23:40:54 UTC) #2
jam
the linux one looks like a flake in the compile step. the earlier try succeeded. ...
8 years, 12 months ago (2011-12-29 23:43:14 UTC) #3
Dmitry Lomov (no reviews)
8 years, 12 months ago (2011-12-29 23:44:14 UTC) #4
lgtm in that case
On 2011/12/29 23:43:14, John Abd-El-Malek wrote:
> the linux one looks like a flake in the compile step. the earlier try
> succeeded. as for windows, that's a checkdeps failure which i've fixed
> locally already.
> 
> don't worry, i only check in with green try runs. i send the review in
> parallel for simple changes like this.
> 
> On Thu, Dec 29, 2011 at 3:40 PM, <mailto:dslomov@chromium.org> wrote:
> 
> > I see some compile failures on linux_rel and win_rel
> >
> >
> >
>
http://codereview.chromium.**org/9052007/%3Chttp://codereview.chromium.org/90...>
> >

Powered by Google App Engine
This is Rietveld 408576698