Make base unit tests work when TEMP has a lower case drive.

Make base unit tests work when TEMP has a lower case drive.

BUG=455470
Committed: https://crrev.com/b7e16e7c951ace558741b4f49f0441814c3397dc
Cr-Commit-Position: refs/heads/master@{#315418}

[rvargas (doing something else), 2015-02-07 03:21:38]

rvargas@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-02-09 16:41:32]

lgtm, but maybe this should be done in ScopedTempDir or GetTempDir in
file_util_win.cc?

[rvargas (doing something else), 2015-02-09 19:29:33]

On 2015/02/09 16:41:32, Nico wrote:
> lgtm, but maybe this should be done in ScopedTempDir or GetTempDir in
> file_util_win.cc?

I'm not so sure about changing the "real" code to do this. On the plus side,
users can have whatever they want... but on the other hand, that also means an
all caps, short-name path, and that gets messy if our code is doing string
comparison anywhere (in general a bad thing to do). I think it's reasonable to
write tests that compare paths against something, but my gut feeling is that's a
broken pattern for production code.

[Nico, 2015-02-09 19:31:28]

On 2015/02/09 19:29:33, rvargas wrote:
> On 2015/02/09 16:41:32, Nico wrote:
> > lgtm, but maybe this should be done in ScopedTempDir or GetTempDir in
> > file_util_win.cc?
> 
> I'm not so sure about changing the "real" code to do this. On the plus side,
> users can have whatever they want... but on the other hand, that also means an
> all caps, short-name path, and that gets messy if our code is doing string
> comparison anywhere (in general a bad thing to do). I think it's reasonable to
> write tests that compare paths against something, but my gut feeling is that's
a
> broken pattern for production code.

I agree we shouldn't upper-case the whole path, but maybe just the driver
letter. Not sur ethough.

[rvargas (doing something else), 2015-02-09 19:57:43]

On 2015/02/09 19:31:28, Nico wrote:
> On 2015/02/09 19:29:33, rvargas wrote:
> > On 2015/02/09 16:41:32, Nico wrote:
> > > lgtm, but maybe this should be done in ScopedTempDir or GetTempDir in
> > > file_util_win.cc?
> > 
> > I'm not so sure about changing the "real" code to do this. On the plus side,
> > users can have whatever they want... but on the other hand, that also means
an
> > all caps, short-name path, and that gets messy if our code is doing string
> > comparison anywhere (in general a bad thing to do). I think it's reasonable
to
> > write tests that compare paths against something, but my gut feeling is
that's
> a
> > broken pattern for production code.
> 
> I agree we shouldn't upper-case the whole path, but maybe just the driver
> letter. Not sur ethough.

IMO any path-related production code should deal with FilePath.

file_path.h (15): // Drive letters     no               case-insensitive A-Z
followed by :

So we are explicitly saying that anyone looking at a drive letter cannot assume
an uppercase. Interestingly enough, there is no method to get just the drive
letter, and getting the underlying value form a FilePath to do manual parsing is
a code smell.

[rvargas (doing something else), 2015-02-09 22:37:49]

The CQ bit was checked by rvargas@chromium.org

[commit-bot: I haz the power, 2015-02-09 22:39:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/905033004/1

[commit-bot: I haz the power, 2015-02-09 22:43:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-09 22:46:14]

Patchset 1 (id:??) landed as
https://crrev.com/b7e16e7c951ace558741b4f49f0441814c3397dc
Cr-Commit-Position: refs/heads/master@{#315418}