Chromium Code Reviews| Index: components/omnibox/omnibox_field_trial.cc |
| diff --git a/components/omnibox/omnibox_field_trial.cc b/components/omnibox/omnibox_field_trial.cc |
| index 74f1100ed0f1de92c567d96db1838c272dd65f16..29139c230df7b0b1fd1f10a6537d33f16f5c952e 100644 |
| --- a/components/omnibox/omnibox_field_trial.cc |
| +++ b/components/omnibox/omnibox_field_trial.cc |
| @@ -289,6 +289,38 @@ int OmniboxFieldTrial::HQPBookmarkValue() { |
| return bookmark_value; |
| } |
| +bool OmniboxFieldTrial::HQPExperimentalScoringEnabled() { |
| + return variations::GetVariationParamValue( |
| + kBundledExperimentFieldTrialName, |
| + kHQPExperimentalScoringEnabledParam) == "true"; |
| +} |
| + |
| +std::string OmniboxFieldTrial::HQPExperimentalScoringBuckets() { |
| + if (!HQPExperimentalScoringEnabled()) |
| + return ""; |
| + |
| + return variations::GetVariationParamValue( |
| + kBundledExperimentFieldTrialName, |
| + kHQPExperimentalScoringBucketsParam); |
| +} |
| + |
| +float OmniboxFieldTrial::HQPExperimentalTopicalityThreshold() { |
| + if (!HQPExperimentalScoringEnabled()) |
| + return -1; |
| + |
| + std::string topicality_threhold_str = |
| + variations::GetVariationParamValue( |
| + kBundledExperimentFieldTrialName, |
| + kHQPExperimentalScoringTopicalityThresholdParam); |
| + |
| + if (topicality_threhold_str.empty()) |
| + return -1; |
| + |
| + double topicality_threshold; |
| + base::StringToDouble(topicality_threhold_str, &topicality_threshold); |
|
Mark P
2015/02/11 21:57:30
You might as well use the return value
Ashok vardhan
2015/02/12 19:56:31
Done.
|
| + return static_cast<float>(topicality_threshold); |
| +} |
| + |
| bool OmniboxFieldTrial::HQPAllowMatchInTLDValue() { |
| return variations::GetVariationParamValue( |
| kBundledExperimentFieldTrialName, |
| @@ -381,6 +413,14 @@ const char OmniboxFieldTrial::kHUPNewScoringVisitedCountHalfLifeTimeParam[] = |
| const char OmniboxFieldTrial::kHUPNewScoringVisitedCountScoreBucketsParam[] = |
| "VisitedCountScoreBuckets"; |
| +const char OmniboxFieldTrial::kHQPExperimentalScoringEnabledParam[] = |
| + "HQPExperimentalScoringEnabled"; |
| +const char OmniboxFieldTrial::kHQPExperimentalScoringBucketsParam[] = |
| + "HQPExperimentalScoringBuckets"; |
| +const char |
| + OmniboxFieldTrial::kHQPExperimentalScoringTopicalityThresholdParam[] = |
| + "HQPExperimentalScoringTopicalityThreshold"; |
| + |
| // static |
| int OmniboxFieldTrial::kDefaultMinimumTimeBetweenSuggestQueriesMs = 100; |