Adding knobs on HQP provider.

components/omnibox/omnibox_field_trial.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
 #define COMPONENTS_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 252 matching lines @@
 
   // Returns true if the search provider should not be caching results.
   static bool DisableResultsCaching();
 
   // Returns how the search provider should poll Suggest. Currently, we support
   // measuring polling delay from the last keystroke or last suggest request.
   static void GetSuggestPollingStrategy(bool* from_last_keystroke,
                                         int* polling_delay_ms);
 
   // ---------------------------------------------------------
+  // For HQP scoring related experiments to control the topicality and scoring
+  // ranges of relevancy scores.
+
+  // Returns true if HQP experimental scoring is enabled. Returns false if
+  // |kHQPExperimentalScoringEnabledParam| is not specified in the field trial.
+  static bool HQPExperimentalScoringEnabled();
+
+  // Returns the scoring buckets for HQP experiments. Returns empty string
+  // in case |kHQPExperimentalScoringBucketsParam| is specified in the field

[Mark P, 2015/02/18 00:03:32]

This sentence is wrong in two ways:
(1) you meant "is not specified"
(2) you missed my earlier correction that you return the empty string even if it
is specified by the enabled param is not specified.

This second comment also applies below.

[Ashok vardhan, 2015/02/18 01:11:21]

Done.

+  // trial. Scoring buckets are stored in string form giving mapping from
+  // (topicality_score, frequency_score) to final relevance score.
+  // Please see GetRelevancyScore() under
+  // chrome/browser/history::ScoredHistoryMatch for details.
+  static std::string HQPExperimentalScoringBuckets();
+
+  // Returns the topicality threshold for HQP experiments. Returns -1 if
+  // |kHQPExperimentalScoringTopicalityThresholdParam| is not specified in the
+  // field trial.
+  static float HQPExperimentalTopicalityThreshold();
+
+  // ---------------------------------------------------------
   // Exposed publicly for the sake of unittests.
   static const char kBundledExperimentFieldTrialName[];
   // Rule names used by the bundled experiment.
   static const char kDisableProvidersRule[];
   static const char kShortcutsScoringMaxRelevanceRule[];
   static const char kSearchHistoryRule[];
   static const char kDemoteByTypeRule[];
   static const char kHQPBookmarkValueRule[];
   static const char kHQPDiscountFrecencyWhenFewVisitsRule[];
   static const char kHQPAllowMatchInTLDRule[];
   static const char kHQPAllowMatchInSchemeRule[];
   static const char kZeroSuggestRule[];
   static const char kZeroSuggestVariantRule[];
   static const char kAnswersInSuggestRule[];
   static const char kDisplayHintTextWhenPossibleRule[];
   static const char kDisableResultsCachingRule[];
   static const char kMeasureSuggestPollingDelayFromLastKeystrokeRule[];
   static const char kSuggestPollingDelayMsRule[];
 
   // Parameter names used by the HUP new scoring experiments.
   static const char kHUPNewScoringEnabledParam[];
   static const char kHUPNewScoringTypedCountRelevanceCapParam[];
   static const char kHUPNewScoringTypedCountHalfLifeTimeParam[];
   static const char kHUPNewScoringTypedCountScoreBucketsParam[];
   static const char kHUPNewScoringVisitedCountRelevanceCapParam[];
   static const char kHUPNewScoringVisitedCountHalfLifeTimeParam[];
   static const char kHUPNewScoringVisitedCountScoreBucketsParam[];
 
+  // Parameter names used by the HQP experimental scoring experiments.
+  static const char kHQPExperimentalScoringEnabledParam[];
+  static const char kHQPExperimentalScoringBucketsParam[];
+  static const char kHQPExperimentalScoringTopicalityThresholdParam[];
+
   // The amount of time to wait before sending a new suggest request after the
   // previous one unless overridden by a field trial parameter.
   // Non-const because some unittests modify this value.
   static int kDefaultMinimumTimeBetweenSuggestQueriesMs;
 
  private:
   friend class OmniboxFieldTrialTest;
 
   // The bundled omnibox experiment comes with a set of parameters
   // (key-value pairs).  Each key indicates a certain rule that applies in
@@ skipping 11 matching lines @@
   // prioritize different wildcard contexts, see the implementation.  How to
   // interpret the value is left to the caller; this is rule-dependent.
   static std::string GetValueForRuleInContext(
       const std::string& rule,
       metrics::OmniboxEventProto::PageClassification page_classification);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial);
 };
 
 #endif  // COMPONENTS_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_