Adding knobs on HQP provider.

components/omnibox/omnibox_field_trial.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
 #define COMPONENTS_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 252 matching lines @@
 
   // Returns true if the search provider should not be caching results.
   static bool DisableResultsCaching();
 
   // Returns how the search provider should poll Suggest. Currently, we support
   // measuring polling delay from the last keystroke or last suggest request.
   static void GetSuggestPollingStrategy(bool* from_last_keystroke,
                                         int* polling_delay_ms);
 
   // ---------------------------------------------------------
+  // For HQP related experiments.

[Mark P, 2015/02/11 21:57:30]

please make this comment clearer about what this section is.  (There are other
"HQP related" experiments in this file.)

[Ashok vardhan, 2015/02/12 19:56:32]

Done.

+  //

[Mark P, 2015/02/11 21:57:30]

nit: want a blank line without a // here, like all other sections

[Ashok vardhan, 2015/02/12 19:56:32]

Done.

+  // Returns true if the HQP experimenal scoring is enabled.

[Mark P, 2015/02/11 21:57:30]

spelling mistake, plus omit "the"

[Ashok vardhan, 2015/02/12 19:56:32]

Done.

+  static bool HQPExperimentalScoringEnabled();
+
+  // Returns the scoring buckets for HQP experiments. Returns empty string
+  // incase not initialized.

[Mark P, 2015/02/11 21:57:30]

1. "in case" is two words.
2. in case what is not "initialized"?  The scoring buckets?  The parameter that
defines the scoring buckets?  ...  Did you mean "defined"?
3. Any function should describe its return type.  How are "scoring buckets"
stored in a string form?  You can point people to a description elsewhere if you
want.
4. Also, I have a minor preference for returning a plausible string as the
return type if the parameter isn't defined; the empty string makes no sense.

[Ashok vardhan, 2015/02/12 19:56:32]

I dont want to return the special string if the experimental scoring is not
enabled. Hence i am returning empty string. Ideally this function is not called,
if experimental scoring is disabled.

Done.

+  static std::string HQPExperimentalScoringBuckets();
+
+  // Returns the topicality threshold for HQP experiments. If it is not
+  // initialized return -1.

[Mark P, 2015/02/11 21:57:30]

again, I think you mean:
it -> the parameter
initialized -> defined

[Ashok vardhan, 2015/02/12 19:56:31]

Done.

+  static float HQPExperimentalTopicalityThreshold();
+
+  // ---------------------------------------------------------
   // Exposed publicly for the sake of unittests.
   static const char kBundledExperimentFieldTrialName[];
   // Rule names used by the bundled experiment.
   static const char kDisableProvidersRule[];
   static const char kShortcutsScoringMaxRelevanceRule[];
   static const char kSearchHistoryRule[];
   static const char kDemoteByTypeRule[];
   static const char kHQPBookmarkValueRule[];
   static const char kHQPDiscountFrecencyWhenFewVisitsRule[];
   static const char kHQPAllowMatchInTLDRule[];
   static const char kHQPAllowMatchInSchemeRule[];
   static const char kZeroSuggestRule[];
   static const char kZeroSuggestVariantRule[];
   static const char kAnswersInSuggestRule[];
   static const char kDisplayHintTextWhenPossibleRule[];
   static const char kDisableResultsCachingRule[];
   static const char kMeasureSuggestPollingDelayFromLastKeystrokeRule[];
   static const char kSuggestPollingDelayMsRule[];
 
   // Parameter names used by the HUP new scoring experiments.
   static const char kHUPNewScoringEnabledParam[];
   static const char kHUPNewScoringTypedCountRelevanceCapParam[];
   static const char kHUPNewScoringTypedCountHalfLifeTimeParam[];
   static const char kHUPNewScoringTypedCountScoreBucketsParam[];
   static const char kHUPNewScoringVisitedCountRelevanceCapParam[];
   static const char kHUPNewScoringVisitedCountHalfLifeTimeParam[];
   static const char kHUPNewScoringVisitedCountScoreBucketsParam[];
 
+  // Parameter names used by the HQP scoring experiments.

[Mark P, 2015/02/11 21:57:30]

insert "experimental", as you're going to do in the earlier comment

[Ashok vardhan, 2015/02/12 19:56:32]

Done.

+  static const char kHQPExperimentalScoringEnabledParam[];
+  static const char kHQPExperimentalScoringBucketsParam[];
+  static const char kHQPExperimentalScoringTopicalityThresholdParam[];
+
   // The amount of time to wait before sending a new suggest request after the
   // previous one unless overridden by a field trial parameter.
   // Non-const because some unittests modify this value.
   static int kDefaultMinimumTimeBetweenSuggestQueriesMs;
 
  private:
   friend class OmniboxFieldTrialTest;
 
   // The bundled omnibox experiment comes with a set of parameters
   // (key-value pairs).  Each key indicates a certain rule that applies in
@@ skipping 11 matching lines @@
   // prioritize different wildcard contexts, see the implementation.  How to
   // interpret the value is left to the caller; this is rule-dependent.
   static std::string GetValueForRuleInContext(
       const std::string& rule,
       metrics::OmniboxEventProto::PageClassification page_classification);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial);
 };
 
 #endif  // COMPONENTS_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_