Rename ParseSourceElements in preparser too

src/preparser.h

Index: src/preparser.h
diff --git a/src/preparser.h b/src/preparser.h
index 982273f447482dc042a4c0d02f2702050b78702e..f3c807cd3a1c6f0c5e2396c8152e3e19900a13dd 100644
--- a/src/preparser.h
+++ b/src/preparser.h
@@ -1564,7 +1564,7 @@ class PreParser : public ParserBase<PreParserTraits> {
                             &factory);
     bool ok = true;
     int start_position = scanner()->peek_location().beg_pos;
-    ParseSourceElements(Token::EOS, &ok);
+    ParseStatementList(Token::EOS, &ok);
     if (stack_overflow()) return kPreParseStackOverflow;
     if (!ok) {
       ReportUnexpectedToken(scanner()->current_token());
@@ -1618,8 +1618,8 @@ class PreParser : public ParserBase<PreParserTraits> {
   // which is set to false if parsing failed; it is unchanged otherwise.
   // By making the 'exception handling' explicit, we are forced to check
   // for failure at the call sites.
-  Statement ParseSourceElement(bool* ok);
-  SourceElements ParseSourceElements(int end_token, bool* ok);
+  Statement ParseStatementListItem(bool* ok);
+  SourceElements ParseStatementList(int end_token, bool* ok);

[adamk, 2015/02/06 22:24:15]

You could also rename the return value, although it's pretty confusing no matter
what the name is.

Actually, could you just get rid of the enum altogether and make this return
void? We already have to redefine the CHECK_OK macro to make the SourceElements
thing work.

[arv (Not doing code reviews), 2015/02/06 22:53:44]

Done.

The return value was never used.

   Statement ParseStatement(bool* ok);
   Statement ParseFunctionDeclaration(bool* ok);
   Statement ParseClassDeclaration(bool* ok);
@@ -1682,7 +1682,7 @@ PreParserStatementList PreParser::ParseEagerFunctionBody(
     Token::Value fvar_init_op, FunctionKind kind, bool* ok) {
   ParsingModeScope parsing_mode(this, PARSE_EAGERLY);
 
-  ParseSourceElements(Token::RBRACE, ok);
+  ParseStatementList(Token::RBRACE, ok);
   if (!*ok) return PreParserStatementList();
 
   Expect(Token::RBRACE, ok);