Rename ParseSourceElements in preparser too

Rename ParseSourceElements in preparser too

BUG=None
R=adamk
LOG=N

Committed: https://crrev.com/8a809a9c8619c26230148b5dccab3039fe9c9b89
Cr-Commit-Position: refs/heads/master@{#26498}

[arv (Not doing code reviews), 2015-02-06 22:07:57]

PTAL

[adamk, 2015-02-06 22:24:15]

lgtm with some more cleanup mentioned if you feel like it.

https://codereview.chromium.org/905003003/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/905003003/diff/1/src/preparser.h#newcode1622
src/preparser.h:1622: SourceElements ParseStatementList(int end_token, bool*
ok);
You could also rename the return value, although it's pretty confusing no matter
what the name is.

Actually, could you just get rid of the enum altogether and make this return
void? We already have to redefine the CHECK_OK macro to make the SourceElements
thing work.

[arv (Not doing code reviews), 2015-02-06 22:50:05]

New patchsets have been uploaded after l-g-t-m from adamk@chromium.org

[arv (Not doing code reviews), 2015-02-06 22:50:06]

Remove kUnknownSourceElements

[arv (Not doing code reviews), 2015-02-06 22:53:44]

PTAL

cq+ if it looks good to you.

https://codereview.chromium.org/905003003/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/905003003/diff/1/src/preparser.h#newcode1622
src/preparser.h:1622: SourceElements ParseStatementList(int end_token, bool*
ok);
On 2015/02/06 22:24:15, adamk wrote:
> You could also rename the return value, although it's pretty confusing no
matter
> what the name is.
> 
> Actually, could you just get rid of the enum altogether and make this return
> void? We already have to redefine the CHECK_OK macro to make the
SourceElements
> thing work.

Done.

The return value was never used.

[adamk, 2015-02-06 23:00:24]

thanks, still lgtm

[adamk, 2015-02-06 23:00:27]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2015-02-06 23:00:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/905003003/20001

[commit-bot: I haz the power, 2015-02-06 23:26:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-06 23:26:45]

Patchset 2 (id:??) landed as
https://crrev.com/8a809a9c8619c26230148b5dccab3039fe9c9b89
Cr-Commit-Position: refs/heads/master@{#26498}