Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 904983002: Add first pixel diffing test. (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang, jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add first pixel diffing test. This is just a simple example of font scaling, so we have some bits to diff against. I've added a /pixel directory to separate these from the embeddertest resources. BUG=https://code.google.com/p/pdfium/issues/detail?id=62 R=jam@chromium.org, thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/77bf6474c50948b1732852bfe0d365d0eaa4c7fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -0 lines) Patch
A testing/resources/pixel/font_size.in View 1 chunk +62 lines, -0 lines 0 comments Download
A testing/resources/pixel/font_size.pdf View 1 chunk +72 lines, -0 lines 0 comments Download
A testing/resources/pixel/font_size_expected.pdf.0.png View Binary file 0 comments Download

Messages

Total messages: 7 (1 generated)
Tom Sepez
Follow-on to the .PNG work we added yesterday to XFA's pdfium_test.
5 years, 10 months ago (2015-02-06 18:55:54 UTC) #2
Lei Zhang
Is there a program that's driving this test, or is that a separate CL?
5 years, 10 months ago (2015-02-06 22:43:34 UTC) #3
Tom Sepez
Separate CL. I imagine it will be a hunk of python.
5 years, 10 months ago (2015-02-06 23:27:58 UTC) #4
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-06 23:36:58 UTC) #5
jam
lgtm
5 years, 10 months ago (2015-02-07 00:01:00 UTC) #6
Tom Sepez
5 years, 10 months ago (2015-02-07 00:06:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
77bf6474c50948b1732852bfe0d365d0eaa4c7fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698