chrome/browser/extensions/api/commands/command_service.h - Issue 904943003: Fixes component extension commands assignment on reload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/commands/command_service.h

Issue 904943003: Fixes component extension commands assignment on reload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/commands/command_service.h

diff --git a/chrome/browser/extensions/api/commands/command_service.h b/chrome/browser/extensions/api/commands/command_service.h

index e886c4c501a271026c5a6ac907c0d7a3039a27d6..bf2dc9e41f38b88b8b685870518042a4a70a877f 100644

--- a/chrome/browser/extensions/api/commands/command_service.h

+++ b/chrome/browser/extensions/api/commands/command_service.h

@@ -201,8 +201,6 @@ class CommandService : public BrowserContextKeyedAPI,

void OnExtensionUninstalled(content::BrowserContext* browser_context,

const Extension* extension,

extensions::UninstallReason reason) override;

- void OnExtensionLoaded(content::BrowserContext* browser_context,

- const Extension* extension) override;

// Updates keybindings for a given |extension|'s page action, browser action

// and named commands. Assigns new keybindings and removes relinquished

« no previous file with comments | « no previous file | chrome/browser/extensions/api/commands/command_service.cc » ('j') | no next file with comments »