extensions/browser/uninstall_reason.h - Issue 904943003: Fixes component extension commands assignment on reload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/uninstall_reason.h

Issue 904943003: Fixes component extension commands assignment on reload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/commands/command_service.cc ('K') | « chrome/test/data/extensions/api_test/keybinding/component/manifest.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/uninstall_reason.h

diff --git a/extensions/browser/uninstall_reason.h b/extensions/browser/uninstall_reason.h

index 191b6a48db79bd14021b31e1215b3e30eb84c543..a50325d0e8229344c9ce4ce1e4d3c9c1088c38f1 100644

--- a/extensions/browser/uninstall_reason.h

+++ b/extensions/browser/uninstall_reason.h

@@ -22,7 +22,8 @@ enum UninstallReason {

UNINSTALL_REASON_ORPHANED_EXTERNAL_EXTENSION,

UNINSTALL_REASON_ORPHANED_SHARED_MODULE,

UNINSTALL_REASON_INTERNAL_MANAGEMENT, // Internal extensions (see usages)

- UNINSTALL_REASON_REINSTALL

+ UNINSTALL_REASON_REINSTALL,

+ UNINSTALL_REASON_COMPONENT

not at google - send to devlin 2015/02/20 16:14:50 "COMPONENT" doesn't sound like an uninstall reason

David Tseng 2015/02/20 18:01:09 Done.

};

} // namespace extensions

« chrome/browser/extensions/api/commands/command_service.cc ('K') | « chrome/test/data/extensions/api_test/keybinding/component/manifest.json ('k') | no next file » | no next file with comments »