Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: extensions/browser/uninstall_reason.h

Issue 904943003: Fixes component extension commands assignment on reload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/uninstall_reason.h
diff --git a/extensions/browser/uninstall_reason.h b/extensions/browser/uninstall_reason.h
index 191b6a48db79bd14021b31e1215b3e30eb84c543..f94b88042b2a0df1244dbadd0f9ad0fb6556b9bf 100644
--- a/extensions/browser/uninstall_reason.h
+++ b/extensions/browser/uninstall_reason.h
@@ -22,7 +22,10 @@ enum UninstallReason {
UNINSTALL_REASON_ORPHANED_EXTERNAL_EXTENSION,
UNINSTALL_REASON_ORPHANED_SHARED_MODULE,
UNINSTALL_REASON_INTERNAL_MANAGEMENT, // Internal extensions (see usages)
- UNINSTALL_REASON_REINSTALL
+ UNINSTALL_REASON_REINSTALL,
+ // Component extensions will only ever install once, but can notify uninstall
+ // repeatedly. crbug.com/458612.
Finnur 2015/02/18 11:51:31 This comment seems out of place. Moving it to wher
David Tseng 2015/02/18 18:24:41 Done.
+ UNINSTALL_REASON_COMPONENT
Finnur 2015/02/18 11:51:31 nit: Add trailing comma.
David Tseng 2015/02/18 18:24:41 Is this convention? This wasn't done before, so le
Finnur 2015/02/20 10:31:49 Yes, it is convention to add a trailing comma to p
David Tseng 2015/02/20 18:12:45 Makes sense. Done.
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698