Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: chrome/test/data/extensions/api_test/keybinding/component/background.js

Issue 904943003: Fixes component extension commands assignment on reload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move clearing to OnExtensionUninstalled Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 var platformBinding = /Mac/.test(navigator.platform) ? 'Command+Shift+5' :
6 'Ctrl+Shift+5';
7 chrome.commands.getAll(function(commands) {
8 chrome.test.assertEq(1, commands.length);
9 chrome.test.assertEq(platformBinding, commands[0].shortcut);
Mike Wittman 2015/02/13 22:11:20 Can you move the keybinding checks into C++ to mat
David Tseng 2015/02/20 19:13:37 Unfortunately, I can't reuse because component ext
Mike Wittman 2015/02/20 19:21:11 Sounds reasonable. I'm OK with the name as-is.
10 chrome.test.notifyPass();
11 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698