Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: components/plugins/renderer/loadable_plugin_placeholder.h

Issue 904913003: Plugin Power Saver: Fix implicitly sized and below the fold plugins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/plugins/renderer/loadable_plugin_placeholder.h
diff --git a/components/plugins/renderer/loadable_plugin_placeholder.h b/components/plugins/renderer/loadable_plugin_placeholder.h
index 401ec7d2995e8b03cc4759c0b12ad96ed61aca2b..ee24663b9ab6388b5caef83c08b9c404969adf37 100644
--- a/components/plugins/renderer/loadable_plugin_placeholder.h
+++ b/components/plugins/renderer/loadable_plugin_placeholder.h
@@ -26,8 +26,8 @@ class LoadablePluginPlaceholder
}
#if defined(ENABLE_PLUGINS)
- void set_power_saver_mode(content::PluginPowerSaverMode power_saver_mode) {
- power_saver_mode_ = power_saver_mode;
+ void set_power_saver_enabled(bool power_saver_enabled) {
+ power_saver_enabled_ = power_saver_enabled;
}
// Defer loading of plug-in, and instead show the Power Saver poster image.
@@ -50,7 +50,7 @@ class LoadablePluginPlaceholder
~LoadablePluginPlaceholder() override;
#if defined(ENABLE_PLUGINS)
- void DisablePowerSaverForInstance(
+ void MarkPluginEssential(
content::PluginInstanceThrottler::PowerSaverUnthrottleMethod method);
#endif
@@ -117,7 +117,10 @@ class LoadablePluginPlaceholder
bool is_blocked_for_power_saver_poster_;
// This is independent of deferred plugin load due to a Power Saver poster.
- content::PluginPowerSaverMode power_saver_mode_;
+ bool power_saver_enabled_;
+
+ // True if the plugin has been marked essential.
+ bool plugin_marked_essential_;
// When we load, uses this premade plugin instead of creating a new one.
blink::WebPlugin* premade_plugin_;
« no previous file with comments | « chrome/renderer/plugins/plugin_preroller.cc ('k') | components/plugins/renderer/loadable_plugin_placeholder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698