Plugin Power Saver: Fix implicitly sized and below the fold plugins.

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include "base/command_line.h"
 #include "base/debug/crash_logging.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
@@ skipping 137 matching lines @@
 #if defined(OS_WIN)
 #include "chrome_elf/blacklist/blacklist.h"
 #endif
 
 using autofill::AutofillAgent;
 using autofill::PasswordAutofillAgent;
 using autofill::PasswordGenerationAgent;
 using base::ASCIIToUTF16;
 using base::UserMetricsAction;
 using content::PluginInstanceThrottler;
-using content::PluginPowerSaverMode;
 using content::RenderFrame;
 using content::RenderThread;
 using content::WebPluginInfo;
 using extensions::Extension;
 using blink::WebCache;
 using blink::WebConsoleMessage;
 using blink::WebDataSource;
 using blink::WebDocument;
 using blink::WebFrame;
 using blink::WebLocalFrame;
@@ skipping 93 matching lines @@
 #if defined(ENABLE_EXTENSIONS)
 void IsGuestViewApiAvailableToScriptContext(
     bool* api_is_available,
     extensions::ScriptContext* context) {
   if (context->GetAvailability("guestViewInternal").is_available()) {
     *api_is_available = true;
   }
 }
 #endif
 
+#if defined(ENABLE_PLUGINS)
+GURL GetPluginInstancePosterImage(const blink::WebPluginParams& params,
+                                  const GURL& page_base_url) {
+  DCHECK_EQ(params.attributeNames.size(), params.attributeValues.size());
+
+  for (size_t i = 0; i < params.attributeNames.size(); ++i) {
+    if (params.attributeNames[i] == "poster") {

[Lei Zhang, 2015/02/09 20:02:05]

Should this be params.attributeNames[i].utf8() ? Not obvious how the WebString
vs const char [] comparison actually happens.

[tommycli, 2015/02/09 20:12:16]

Done.

+      std::string poster_value(params.attributeValues[i].utf8());
+      if (!poster_value.empty())

[Lei Zhang, 2015/02/09 20:02:05]

You can call isEmpty() on the WebString, and only convert it to a std::string if
it's not empty.

[tommycli, 2015/02/09 20:12:16]

Done.

+        return page_base_url.Resolve(poster_value);
+    }
+  }
+  return GURL();
+}
+#endif
+
 }  // namespace
 
 ChromeContentRendererClient::ChromeContentRendererClient() {
   g_current_client = this;
 
 #if defined(ENABLE_EXTENSIONS)
   extensions::ExtensionsClient::Set(
       extensions::ChromeExtensionsClient::GetInstance());
   extensions::ExtensionsRendererClient::Set(
       ChromeExtensionsRendererClient::GetInstance());
@@ skipping 507 matching lines @@
   #if defined(OS_CHROMEOS)
                 l10n_util::GetStringUTF16(IDS_NACL_PLUGIN_BLOCKED));
   #else
                 l10n_util::GetStringFUTF16(IDS_PLUGIN_BLOCKED, group_name));
   #endif
             break;
           }
         }
 #endif  // !defined(DISABLE_NACL) && defined(ENABLE_EXTENSIONS)
 
-        scoped_ptr<content::PluginInstanceThrottler> throttler;
 #if defined(ENABLE_PLUGINS)
-        PluginPowerSaverMode power_saver_mode =
-            PluginPowerSaverMode::POWER_SAVER_MODE_ESSENTIAL;
-        bool show_poster = false;
+        bool power_saver_enabled =
+            status_value ==
+            ChromeViewHostMsg_GetPluginInfo_Status::kPlayImportantContent;
+        bool blocked_for_background_tab =
+            render_frame->IsHidden() && power_saver_enabled;
+
         GURL poster_url;
-        bool cross_origin_main_content = false;
-        bool blocked_for_background_tab =
-            render_frame->IsHidden() &&
-            status_value ==
-                ChromeViewHostMsg_GetPluginInfo_Status::kPlayImportantContent;
-        if (render_frame->ShouldThrottleContent(params, frame->document().url(),
-                                                &poster_url,
-                                                &cross_origin_main_content)) {
-          // TODO(tommycli): Apply throttler behavior to all plugins.
-          if (info.name == base::ASCIIToUTF16(content::kFlashPluginName) &&
-              status_value == ChromeViewHostMsg_GetPluginInfo_Status::
-                                  kPlayImportantContent) {
-            power_saver_mode =
-                PluginPowerSaverMode::POWER_SAVER_MODE_PERIPHERAL_THROTTLED;
-            show_poster = poster_url.is_valid();
-          } else {
-            power_saver_mode =
-                PluginPowerSaverMode::POWER_SAVER_MODE_PERIPHERAL_UNTHROTTLED;
-          }
-
-          throttler = content::PluginInstanceThrottler::Get(render_frame, url,
-                                                            power_saver_mode);
+        if (power_saver_enabled) {
+          poster_url =
+              GetPluginInstancePosterImage(params, frame->document().url());
         }
 
         // Delay loading plugins if prerendering.
         // TODO(mmenke):  In the case of prerendering, feed into
         //                ChromeContentRendererClient::CreatePlugin instead, to
         //                reduce the chance of future regressions.
         bool is_prerendering =
             prerender::PrerenderHelper::IsPrerendering(render_frame);
-        if (blocked_for_background_tab || is_prerendering || show_poster) {
+        if (blocked_for_background_tab || is_prerendering ||
+            poster_url.is_valid()) {
           placeholder = ChromePluginPlaceholder::CreateBlockedPlugin(
               render_frame, frame, params, info, identifier, group_name,
-              show_poster ? IDR_PLUGIN_POSTER_HTML : IDR_BLOCKED_PLUGIN_HTML,
+              poster_url.is_valid() ? IDR_PLUGIN_POSTER_HTML
+                                    : IDR_BLOCKED_PLUGIN_HTML,
               l10n_util::GetStringFUTF16(IDS_PLUGIN_BLOCKED, group_name),
               poster_url);
           placeholder->set_blocked_for_background_tab(
               blocked_for_background_tab);
           placeholder->set_blocked_for_prerendering(is_prerendering);
-          placeholder->set_power_saver_mode(power_saver_mode);
+          placeholder->set_power_saver_enabled(power_saver_enabled);
           placeholder->set_allow_loading(true);
           break;
-        } else if (cross_origin_main_content) {
-          GURL content_origin = GURL(params.url).GetOrigin();
-          render_frame->WhitelistContentOrigin(content_origin);
         }
 
-        if (power_saver_mode ==
-            PluginPowerSaverMode::POWER_SAVER_MODE_PERIPHERAL_THROTTLED) {
-          content::PluginInstanceThrottler* throttler_raw = throttler.get();
-          blink::WebPlugin* plugin =
-              render_frame->CreatePlugin(frame, info, params, throttler.Pass());
+        scoped_ptr<content::PluginInstanceThrottler> throttler =
+            PluginInstanceThrottler::Create(power_saver_enabled);
+        content::PluginInstanceThrottler* throttler_raw = throttler.get();
+        blink::WebPlugin* plugin =
+            render_frame->CreatePlugin(frame, info, params, throttler.Pass());
 
+        if (power_saver_enabled) {
           // PluginPreroller manages its own lifetime.
           new PluginPreroller(
               render_frame, frame, params, info, identifier, group_name,
               l10n_util::GetStringFUTF16(IDS_PLUGIN_BLOCKED, group_name),
               plugin, throttler_raw);
-
-          return plugin;
         }
 
+        return plugin;
+#else   // !defined(ENABLE_PLUGINS)
+        return render_frame->CreatePlugin(frame, info, params, nullptr);
 #endif  // defined(ENABLE_PLUGINS)
-        return render_frame->CreatePlugin(frame, info, params,
-                                          throttler.Pass());
       }
       case ChromeViewHostMsg_GetPluginInfo_Status::kNPAPINotSupported: {
         RenderThread::Get()->RecordAction(
             UserMetricsAction("Plugin_NPAPINotSupported"));
         placeholder = create_blocked_plugin(
             IDR_BLOCKED_PLUGIN_HTML,
             l10n_util::GetStringUTF16(IDS_PLUGIN_NOT_SUPPORTED_METRO));
         render_frame->Send(new ChromeViewHostMsg_NPAPINotSupported(
             render_frame->GetRoutingID(), identifier));
         break;
@@ skipping 722 matching lines @@
   if (mime_type == content::kBrowserPluginMimeType) {
     return new extensions::ExtensionsGuestViewContainer(render_frame);
   } else {
     return new extensions::MimeHandlerViewContainer(
         render_frame, mime_type, original_url);
   }
 #else
   return NULL;
 #endif
 }