Plugin Power Saver: Fix implicitly sized and below the fold plugins.

content/public/renderer/plugin_instance_throttler.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_PLUGIN_INSTANCE_THROTTLER_H_
 #define CONTENT_PUBLIC_RENDERER_PLUGIN_INSTANCE_THROTTLER_H_
 
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/common/content_export.h"
 
+namespace blink {
+struct WebPluginParams;
+}
+
 class GURL;
 class SkBitmap;
 
 namespace content {
 
-class RenderFrame;
-
-// Plugin instances are "peripheral" if they are heuristically determined to be
-// not "essential" to the web page content. See comments on
-// RenderFrame::ShouldThrottleContent for details on these heuristics.
-enum PluginPowerSaverMode {
-  // Plugin content is main content, and therefore never throttled.
-  POWER_SAVER_MODE_ESSENTIAL = 0,
-  // Plugin content is peripheral, but throttling is disabled.
-  POWER_SAVER_MODE_PERIPHERAL_UNTHROTTLED = 1,
-  // Plugin content is peripheral, and throttling is enabled.
-  POWER_SAVER_MODE_PERIPHERAL_THROTTLED = 2
-};
-
 // This class manages the metric collection, throttling, and unthrottling of a
 // single peripheral plugin instance. If the Power Saver feature is disabled,
 // the plugin instance will never actually be throttled, but still collects
 // user interaction metrics.
 //
 // The process for throttling a plugin is as follows:
 // 1) Attempt to find a representative keyframe to display as a placeholder for
 //    the plugin.
 // 2) a) If a representative keyframe is found, throttle the plugin at that
 //       keyframe.
@@ skipping 25 matching lines @@
     virtual void OnKeyframeExtracted(const SkBitmap* bitmap) {}
 
     virtual void OnThrottleStateChange() {}
 
     // Called when the plugin should be hidden due to a placeholder.
     virtual void OnHiddenForPlaceholder(bool hidden) {}
 
     virtual void OnThrottlerDestroyed() {}
   };
 
-  // Returns a nullptr if no throttler needed based on |power_saver_mode|.
-  static scoped_ptr<PluginInstanceThrottler> Get(
-      RenderFrame* frame,
-      const GURL& plugin_url,
-      PluginPowerSaverMode power_saver_mode);
+  static scoped_ptr<PluginInstanceThrottler> Create(bool power_saver_enabled);
+
+  static GURL GetPluginInstancePosterImage(const blink::WebPluginParams& params,
+                                           const GURL& page_base_url);

[piman, 2015/02/06 22:13:12]

Why is this even here? It doesn't need anything from content/ and could be
implemented directly in ChromeContentRendererClient?

[tommycli, 2015/02/06 22:57:10]

Done. It was to support a unit test. But I think the method is trivial enough to
not require a unit test, so I moved it.

 
   static void RecordUnthrottleMethodMetric(PowerSaverUnthrottleMethod method);
 
   virtual ~PluginInstanceThrottler() {}
 
   virtual void AddObserver(Observer* observer) = 0;
   virtual void RemoveObserver(Observer* observer) = 0;
 
   virtual bool IsThrottled() const = 0;
   virtual bool IsHiddenForPlaceholder() const = 0;
 
   // Marks the plugin as essential. Unthrottles the plugin if already throttled.
   virtual void MarkPluginEssential(PowerSaverUnthrottleMethod method) = 0;
 
   // Called by the placeholder when the plugin should temporarily be hidden.
   virtual void SetHiddenForPlaceholder(bool hidden) = 0;
 
  protected:
   PluginInstanceThrottler() {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PluginInstanceThrottler);
 };
 }
 
 #endif  // CONTENT_PUBLIC_RENDERER_PLUGIN_INSTANCE_THROTTLER_H_