Plugin Power Saver: Fix implicitly sized and below the fold plugins.

content/renderer/pepper/plugin_power_saver_helper.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/plugin_power_saver_helper.h"
 
 #include "base/metrics/histogram.h"
 #include "base/strings/string_number_conversions.h"
 #include "content/common/frame_messages.h"
+#include "content/public/common/content_constants.h"
 #include "content/public/renderer/document_state.h"
 #include "content/public/renderer/navigation_state.h"
 #include "content/public/renderer/render_frame.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebPluginParams.h"
 #include "third_party/WebKit/public/web/WebView.h"
 
 namespace content {
 
 namespace {
 
-const char kPosterParamName[] = "poster";
-
 // Initial decision of the peripheral content decision.
 // These numeric values are used in UMA logs; do not change them.
 enum PeripheralHeuristicDecision {
   HEURISTIC_DECISION_PERIPHERAL = 0,
   HEURISTIC_DECISION_ESSENTIAL_SAME_ORIGIN = 1,
   HEURISTIC_DECISION_ESSENTIAL_CROSS_ORIGIN_BIG = 2,
   HEURISTIC_DECISION_ESSENTIAL_CROSS_ORIGIN_WHITELISTED = 3,
   HEURISTIC_DECISION_ESSENTIAL_CROSS_ORIGIN_TINY = 4,
   HEURISTIC_DECISION_NUM_ITEMS
 };
 
 const char kPeripheralHeuristicHistogram[] =
     "Plugin.PowerSaver.PeripheralHeuristic";
 
 // Maximum dimensions plug-in content may have while still being considered
 // peripheral content. These match the sizes used by Safari.
 const int kPeripheralContentMaxWidth = 400;
 const int kPeripheralContentMaxHeight = 300;
 
 // Plug-in content below this size in height and width is considered "tiny".
 // Tiny content is never peripheral, as tiny plug-ins often serve a critical
 // purpose, and the user often cannot find and click to unthrottle it.
 const int kPeripheralContentTinySize = 5;
 
 void RecordDecisionMetric(PeripheralHeuristicDecision decision) {
   UMA_HISTOGRAM_ENUMERATION(kPeripheralHeuristicHistogram, decision,
                             HEURISTIC_DECISION_NUM_ITEMS);
 }
 
-const char kWebPluginParamHeight[] = "height";
-const char kWebPluginParamWidth[] = "width";
-
-// Returns true if valid non-negative height and width extracted.
-// When this returns false, |width| and |height| are set to undefined values.
-bool ExtractDimensions(const blink::WebPluginParams& params,
-                       int* width,
-                       int* height) {
-  DCHECK_EQ(params.attributeNames.size(), params.attributeValues.size());
-  DCHECK(width);
-  DCHECK(height);
-  bool width_extracted = false;
-  bool height_extracted = false;
-  for (size_t i = 0; i < params.attributeNames.size(); ++i) {
-    if (params.attributeNames[i].utf8() == kWebPluginParamWidth) {
-      width_extracted =
-          base::StringToInt(params.attributeValues[i].utf8(), width);
-    } else if (params.attributeNames[i].utf8() == kWebPluginParamHeight) {
-      height_extracted =
-          base::StringToInt(params.attributeValues[i].utf8(), height);
-    }
-  }
-  return width_extracted && height_extracted && *width >= 0 && *height >= 0;
-}
-
-GURL GetPluginInstancePosterImage(const blink::WebPluginParams& params,
-                                  const GURL& page_base_url) {
-  DCHECK_EQ(params.attributeNames.size(), params.attributeValues.size());
-
-  for (size_t i = 0; i < params.attributeNames.size(); ++i) {
-    if (params.attributeNames[i] == kPosterParamName) {
-      std::string poster_value(params.attributeValues[i].utf8());
-      if (!poster_value.empty())
-        return page_base_url.Resolve(poster_value);
-    }
-  }
-  return GURL();
-}
-
 }  // namespace
 
 PluginPowerSaverHelper::PeripheralPlugin::PeripheralPlugin(
     const GURL& content_origin,
     const base::Closure& unthrottle_callback)
     : content_origin(content_origin), unthrottle_callback(unthrottle_callback) {
 }
 
 PluginPowerSaverHelper::PeripheralPlugin::~PeripheralPlugin() {
 }
@@ skipping 39 matching lines @@
       it = peripheral_plugins_.erase(it);
     } else {
       ++it;
     }
   }
 }
 
 void PluginPowerSaverHelper::RegisterPeripheralPlugin(
     const GURL& content_origin,
     const base::Closure& unthrottle_callback) {
+  DCHECK_EQ(content_origin.GetOrigin(), content_origin);
   peripheral_plugins_.push_back(
       PeripheralPlugin(content_origin, unthrottle_callback));
 }
 
 bool PluginPowerSaverHelper::ShouldThrottleContent(
-    const blink::WebPluginParams& params,
-    const GURL& plugin_frame_url,
-    GURL* poster_image,
+    const GURL& content_origin,
+    const std::string& plugin_module_name,
+    int width,
+    int height,
     bool* cross_origin_main_content) const {
-  if (poster_image)
-    *poster_image = GURL();
+  DCHECK_EQ(content_origin.GetOrigin(), content_origin);
   if (cross_origin_main_content)
     *cross_origin_main_content = false;
 
-  GURL content_origin = GURL(params.url).GetOrigin();
+  // This feature has only been tested throughly with Flash thus far.
+  if (plugin_module_name != content::kFlashPluginName)
+    return false;
 
-  int width = 0;
-  int height = 0;
-  if (!ExtractDimensions(params, &width, &height))
+  if (width <= 0 || height <= 0)
     return false;
 
   // TODO(alexmos): Update this to use the origin of the RemoteFrame when 426512
   // is fixed. For now, case 3 in the class level comment doesn't work in
   // --site-per-process mode.
   blink::WebFrame* main_frame =
       render_frame()->GetWebFrame()->view()->mainFrame();
   if (main_frame->isWebRemoteFrame()) {
     RecordDecisionMetric(HEURISTIC_DECISION_PERIPHERAL);
-    if (poster_image)
-      *poster_image = GetPluginInstancePosterImage(params, plugin_frame_url);
     return true;
   }
 
   // All same-origin plugin content is essential.
   GURL main_frame_origin = GURL(main_frame->document().url()).GetOrigin();
   if (content_origin == main_frame_origin) {
     RecordDecisionMetric(HEURISTIC_DECISION_ESSENTIAL_SAME_ORIGIN);
     return false;
   }
 
@@ skipping 13 matching lines @@
   // Plugin content large in both dimensions are the "main attraction".
   if (width >= kPeripheralContentMaxWidth &&
       height >= kPeripheralContentMaxHeight) {
     RecordDecisionMetric(HEURISTIC_DECISION_ESSENTIAL_CROSS_ORIGIN_BIG);
     if (cross_origin_main_content)
       *cross_origin_main_content = true;
     return false;
   }
 
   RecordDecisionMetric(HEURISTIC_DECISION_PERIPHERAL);
-  if (poster_image)
-    *poster_image = GetPluginInstancePosterImage(params, plugin_frame_url);
   return true;
 }
 
 void PluginPowerSaverHelper::WhitelistContentOrigin(
     const GURL& content_origin) {
   DCHECK_EQ(content_origin.GetOrigin(), content_origin);
   if (origin_whitelist_.insert(content_origin).second) {
     Send(new FrameHostMsg_PluginContentOriginAllowed(
         render_frame()->GetRoutingID(), content_origin));
   }
 }
 
 }  // namespace content