in dartc, generics in Typedef not working as expected, when extending generic type

in dartc, generics in Typedef not working as expected, when extending generic type

http://code.google.com/p/dart/issues/detail?id=436

Committed: https://code.google.com/p/dart/source/detail?r=3103

[zundel, 2012-01-04 21:28:52]

http://codereview.chromium.org/9049016/diff/1/tests/language/src/FunctionType...
File tests/language/src/FunctionTypeAliasTest.dart (right):

http://codereview.chromium.org/9049016/diff/1/tests/language/src/FunctionType...
tests/language/src/FunctionTypeAliasTest.dart:102: Expect.isFalse(boundsFalse is
BoundsCheck<num>);
The way I wanted to write this test was:

Expect.isFalse(boundsFalse is BoundsCheck);

But that substitutes 'Dynamic' for the type parameter and the is-expression
evaluates to true.

[scheglov, 2012-01-04 21:51:43]

lgtm in general

http://codereview.chromium.org/9049016/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java
(right):

http://codereview.chromium.org/9049016/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java:97:
private void setBoundsOnTypeParameters(List<?extends Type> typeParameters,
"<?extends" space missing.

http://codereview.chromium.org/9049016/diff/1/compiler/javatests/com/google/d...
File compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
(right):

http://codereview.chromium.org/9049016/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java:1097:
"typedef List<T> TypeAlias<T, U extends List<T>>(List<T> arg, U u);"));
I'd like to see in JUnit test some deeper  check, like check that all type
bounds are actually resolved to the corresponding types. But you may be will
have to make change in "resolveAndTest" to save DartUnit in a field.

[codefu, 2012-01-06 20:32:14]

lgtm

[zundel, 2012-01-09 16:02:49]

http://codereview.chromium.org/9049016/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java
(right):

http://codereview.chromium.org/9049016/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java:97:
private void setBoundsOnTypeParameters(List<?extends Type> typeParameters,
On 2012/01/04 21:51:43, scheglov wrote:
> "<?extends" space missing.

Done.

http://codereview.chromium.org/9049016/diff/1/compiler/javatests/com/google/d...
File compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
(right):

http://codereview.chromium.org/9049016/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java:1097:
"typedef List<T> TypeAlias<T, U extends List<T>>(List<T> arg, U u);"));
On 2012/01/04 21:51:43, scheglov wrote:
> I'd like to see in JUnit test some deeper  check, like check that all type
> bounds are actually resolved to the corresponding types. But you may be will
> have to make change in "resolveAndTest" to save DartUnit in a field.

I moved the test to ResolverCompilerTest.  See if what I did there is what you
had in mind.

[scheglov, 2012-01-09 16:12:48]

LGTM

Yes, now it tests types and their bounds.


> "typedef List<T> TypeAlias<T, U extends List<T>>(List<T> arg, U u);"));
> On 2012/01/04 21:51:43, scheglov wrote:
> > I'd like to see in JUnit test some deeper  check, like check that all type
> > bounds are actually resolved to the corresponding types. But you may be will
> > have to make change in "resolveAndTest" to save DartUnit in a field.
> 
> I moved the test to ResolverCompilerTest.  See if what I did there is what you
> had in mind.

[codefu, 2012-01-09 17:01:29]

still lgtm