src/hydrogen-types.cc - Issue 904863002: [turbofan] Separate representation type operations from the semantic types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-types.cc

Issue 904863002: [turbofan] Separate representation type operations from the semantic types. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fixes Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen-types.cc

diff --git a/src/hydrogen-types.cc b/src/hydrogen-types.cc

index 4f5eabb2df82300acc1a02b87f5cbe9bbf05ef9d..3bac69bb569ae658c1448d955023591c611e07a5 100644

--- a/src/hydrogen-types.cc

+++ b/src/hydrogen-types.cc

@@ -15,7 +15,7 @@ namespace internal {

template <class T>

HType HType::FromType(typename T::TypeHandle type) {

if (T::Any()->Is(type)) return HType::Any();

- if (type->Is(T::None())) return HType::None();

+ if (!type->IsInhabited()) return HType::None();

if (type->Is(T::SignedSmall())) return HType::Smi();

if (type->Is(T::Number())) return HType::TaggedNumber();

if (type->Is(T::Null())) return HType::Null();

« no previous file with comments | « src/compiler/typer.cc ('k') | src/types.h » ('j') | no next file with comments »