Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 904833004: Add test_runner hook to dump drag image. (Closed)

Created:
5 years, 10 months ago by jackhou1
Modified:
5 years, 10 months ago
Reviewers:
tkent, Justin Novosad
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test_runner hook to dump drag image. This is used by: https://codereview.chromium.org/886323005/ BUG=451759 Committed: https://crrev.com/3726d659908604350bc03ef02d1ccc5cdc097dd5 Cr-Commit-Position: refs/heads/master@{#315915}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Dump drag image as pixel results. #

Total comments: 2

Patch Set 3 : Address comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M content/shell/renderer/test_runner/test_runner.h View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 1 6 chunks +17 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.h View 1 3 chunks +3 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 2 chunks +9 lines, -0 lines 2 comments Download

Messages

Total messages: 19 (4 generated)
jackhou1
https://codereview.chromium.org/904833004/diff/1/content/shell/renderer/test_runner/web_test_proxy.cc File content/shell/renderer/test_runner/web_test_proxy.cc (right): https://codereview.chromium.org/904833004/diff/1/content/shell/renderer/test_runner/web_test_proxy.cc#newcode814 content/shell/renderer/test_runner/web_test_proxy.cc:814: base::Base64Encode(base::StringPiece(static_cast<char*>(bitmap.getPixels()), Is there a better way to represent the ...
5 years, 10 months ago (2015-02-10 01:54:21 UTC) #2
Justin Novosad
https://codereview.chromium.org/904833004/diff/1/content/shell/renderer/test_runner/web_test_proxy.cc File content/shell/renderer/test_runner/web_test_proxy.cc (right): https://codereview.chromium.org/904833004/diff/1/content/shell/renderer/test_runner/web_test_proxy.cc#newcode814 content/shell/renderer/test_runner/web_test_proxy.cc:814: base::Base64Encode(base::StringPiece(static_cast<char*>(bitmap.getPixels()), On 2015/02/10 01:54:20, jackhou1 wrote: > Is there ...
5 years, 10 months ago (2015-02-10 22:37:48 UTC) #3
jackhou1
https://codereview.chromium.org/904833004/diff/1/content/shell/renderer/test_runner/web_test_proxy.cc File content/shell/renderer/test_runner/web_test_proxy.cc (right): https://codereview.chromium.org/904833004/diff/1/content/shell/renderer/test_runner/web_test_proxy.cc#newcode814 content/shell/renderer/test_runner/web_test_proxy.cc:814: base::Base64Encode(base::StringPiece(static_cast<char*>(bitmap.getPixels()), On 2015/02/10 22:37:48, junov wrote: > On 2015/02/10 ...
5 years, 10 months ago (2015-02-11 00:08:25 UTC) #4
jackhou1
PTAL
5 years, 10 months ago (2015-02-11 00:30:16 UTC) #5
Justin Novosad
On 2015/02/11 00:30:16, jackhou1 wrote: > PTAL Ah! That's a lot more useful. non-owner lgtm
5 years, 10 months ago (2015-02-11 04:23:25 UTC) #6
jackhou1
tkent, could you please take a look?
5 years, 10 months ago (2015-02-11 05:04:45 UTC) #8
tkent
lgtm https://codereview.chromium.org/904833004/diff/20001/content/shell/renderer/test_runner/test_runner.h File content/shell/renderer/test_runner/test_runner.h (right): https://codereview.chromium.org/904833004/diff/20001/content/shell/renderer/test_runner/test_runner.h#newcode473 content/shell/renderer/test_runner/test_runner.h:473: // This function sets a flag which tells ...
5 years, 10 months ago (2015-02-12 00:50:50 UTC) #9
jackhou1
https://codereview.chromium.org/904833004/diff/20001/content/shell/renderer/test_runner/test_runner.h File content/shell/renderer/test_runner/test_runner.h (right): https://codereview.chromium.org/904833004/diff/20001/content/shell/renderer/test_runner/test_runner.h#newcode473 content/shell/renderer/test_runner/test_runner.h:473: // This function sets a flag which tells the ...
5 years, 10 months ago (2015-02-12 02:05:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904833004/40001
5 years, 10 months ago (2015-02-12 02:06:00 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-12 02:44:39 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/3726d659908604350bc03ef02d1ccc5cdc097dd5 Cr-Commit-Position: refs/heads/master@{#315915}
5 years, 10 months ago (2015-02-12 02:46:03 UTC) #15
tkent
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/925743002/ by tkent@chromium.org. ...
5 years, 10 months ago (2015-02-13 02:30:48 UTC) #16
Justin Novosad
https://codereview.chromium.org/904833004/diff/40001/content/shell/renderer/test_runner/web_test_proxy.cc File content/shell/renderer/test_runner/web_test_proxy.cc (right): https://codereview.chromium.org/904833004/diff/40001/content/shell/renderer/test_runner/web_test_proxy.cc#newcode568 content/shell/renderer/test_runner/web_test_proxy.cc:568: if (!drag_image_.isNull()) { Theory on why this this CL ...
5 years, 10 months ago (2015-02-13 03:00:05 UTC) #17
jackhou1
https://codereview.chromium.org/904833004/diff/40001/content/shell/renderer/test_runner/web_test_proxy.cc File content/shell/renderer/test_runner/web_test_proxy.cc (right): https://codereview.chromium.org/904833004/diff/40001/content/shell/renderer/test_runner/web_test_proxy.cc#newcode568 content/shell/renderer/test_runner/web_test_proxy.cc:568: if (!drag_image_.isNull()) { On 2015/02/13 03:00:05, junov wrote: > ...
5 years, 10 months ago (2015-02-13 04:54:44 UTC) #18
jackhou1
5 years, 10 months ago (2015-02-13 04:55:00 UTC) #19
Message was sent while issue was closed.
New CL here: https://codereview.chromium.org/916893003/

Powered by Google App Engine
This is Rietveld 408576698