Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 904833003: Fixed array read error (Closed)

Created:
5 years, 10 months ago by sugoi1
Modified:
5 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fixed array read error In 32 bits, if the "element count" was under 32 bits, but "element count" * "element size" was over the 32 bit limit, the overflow was causing the read operation to appear as if it had succeded, even though it should have failed. BUG=456828 Committed: https://skia.googlesource.com/skia/+/8e85761e5a4a0b169cf101c4d72142ee4b87d266

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/core/SkValidatingReadBuffer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sugoi1
Another size_t overflow similar to the other ones fixed recently.
5 years, 10 months ago (2015-02-09 20:37:31 UTC) #2
reed1
lgtm
5 years, 10 months ago (2015-02-09 21:02:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904833003/1
5 years, 10 months ago (2015-02-09 21:10:38 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 21:17:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8e85761e5a4a0b169cf101c4d72142ee4b87d266

Powered by Google App Engine
This is Rietveld 408576698